From patchwork Sun Dec 18 08:32:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 132055 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5CFBFB6FD3 for ; Sun, 18 Dec 2011 19:33:00 +1100 (EST) Received: (qmail 22445 invoked by alias); 18 Dec 2011 08:32:58 -0000 Received: (qmail 22435 invoked by uid 22791); 18 Dec 2011 08:32:57 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 18 Dec 2011 08:32:40 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id CEE6719D2E; Sun, 18 Dec 2011 09:32:38 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rQtMQkpAKFvX; Sun, 18 Dec 2011 09:32:38 +0100 (CET) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by anubis.se.axis.com (Postfix) with ESMTP id D8AE019D08; Sun, 18 Dec 2011 09:32:37 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id A1A133E0AF; Sun, 18 Dec 2011 09:32:37 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id pBI8WbF6015549; Sun, 18 Dec 2011 09:32:37 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id pBI8WaNQ015545; Sun, 18 Dec 2011 09:32:36 +0100 Date: Sun, 18 Dec 2011 09:32:36 +0100 Message-Id: <201112180832.pBI8WaNQ015545@ignucius.se.axis.com> From: Hans-Peter Nilsson To: Tom_deVries@mentor.com CC: vries@codesourcery.com, gcc-patches@gcc.gnu.org In-reply-to: <4EE9BC8F.8020803@mentor.com> (message from Tom de Vries on Thu, 15 Dec 2011 10:23:27 +0100) Subject: testsuite typo fixed in "[PATCH, PR51491] add CLOBBER before __builtin_stack_restore" when converting vla alloca_with_align to array decl MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > From: Tom de Vries > Date: Thu, 15 Dec 2011 10:23:27 +0100 > bootstrapped and reg-tested (ada inclusive) on x86_64. Time to update your inspection script: there's a missing sanity check for the number of passes. I suggest you re-run regtests for the main change with the below patch applied. > 2011-12-15 Tom de Vries > * gcc.dg/pr51491.c: New test. > * gcc.dg/pr51491-2.c: Same. > Index: gcc/testsuite/gcc.dg/pr51491-2.c > +/* { dg-final { cleanup-treee-dump "ccp1" } } */ Typos like this cause the test-run to be aborted for the current .exp file, in this case, gcc/testsuite/gcc.dg/dg.exp: ERROR: (DejaGnu) proc "cleanup-treee-dump ccp1" does not exist. The error code is NONE The info on the error is: close: spawn id exp5 not open while executing "close -i exp5" invoked from within "catch "close -i $spawn_id"" In this case, some 3000 test-cases went missing, judging by the "gcc Summary" output. Below patch committed as obvious after verifying that it fixed the error. gcc/testsuite: * gcc.dg/pr51491-2.c: Fix "cleanup-treee-dump" typo. brgds, H-P Index: gcc/testsuite/gcc.dg/pr51491-2.c =================================================================== --- gcc/testsuite/gcc.dg/pr51491-2.c (revision 182453) +++ gcc/testsuite/gcc.dg/pr51491-2.c (working copy) @@ -31,4 +31,4 @@ f (int n) } /* { dg-final { scan-tree-dump-times "CLOBBER" 2 "ccp1"} } */ -/* { dg-final { cleanup-treee-dump "ccp1" } } */ +/* { dg-final { cleanup-tree-dump "ccp1" } } */