diff mbox

[PING] Remove obsolete alias check in cgraph_redirect_edge_call_stmt_to_callee

Message ID 20110830163856.GC15358@virgil.arch.suse.de
State New
Headers show

Commit Message

Martin Jambor Aug. 30, 2011, 4:38 p.m. UTC
Hi,

this is a ping of a patch that I have originally posted almost two
months ago.

Since (same body) aliases have their own cgraph_nodes, the check for
them in cgraph_redirect_edge_call_stmt_to_callee is now unnecessary
because e->callee is now the alias, not the function node.

The following patch therefore removes it.  Bootstrapped and tested
again on x86_64-linux yesterday, OK for trunk?

Thanks,

Martin


2011-07-08  Martin Jambor  <mjambor@suse.cz>

	* cgraphunit.c (cgraph_redirect_edge_call_stmt_to_callee): Alias
	check removed.

Comments

Richard Biener Aug. 31, 2011, 7:31 a.m. UTC | #1
On Tue, Aug 30, 2011 at 6:38 PM, Martin Jambor <mjambor@suse.cz> wrote:
>
> Hi,
>
> this is a ping of a patch that I have originally posted almost two
> months ago.
>
> Since (same body) aliases have their own cgraph_nodes, the check for
> them in cgraph_redirect_edge_call_stmt_to_callee is now unnecessary
> because e->callee is now the alias, not the function node.
>
> The following patch therefore removes it.  Bootstrapped and tested
> again on x86_64-linux yesterday, OK for trunk?

Ok.

Thanks,
Richard.

> Thanks,
>
> Martin
>
>
> 2011-07-08  Martin Jambor  <mjambor@suse.cz>
>
>        * cgraphunit.c (cgraph_redirect_edge_call_stmt_to_callee): Alias
>        check removed.
>
> Index: src/gcc/cgraphunit.c
> ===================================================================
> --- src.orig/gcc/cgraphunit.c
> +++ src/gcc/cgraphunit.c
> @@ -2373,9 +2373,7 @@ cgraph_redirect_edge_call_stmt_to_callee
>  #endif
>
>   if (e->indirect_unknown_callee
> -      || decl == e->callee->decl
> -      /* Don't update call from same body alias to the real function.  */
> -      || (decl && cgraph_get_node (decl) == cgraph_get_node (e->callee->decl)))
> +      || decl == e->callee->decl)
>     return e->call_stmt;
>
>  #ifdef ENABLE_CHECKING
>
diff mbox

Patch

Index: src/gcc/cgraphunit.c
===================================================================
--- src.orig/gcc/cgraphunit.c
+++ src/gcc/cgraphunit.c
@@ -2373,9 +2373,7 @@  cgraph_redirect_edge_call_stmt_to_callee
 #endif
 
   if (e->indirect_unknown_callee
-      || decl == e->callee->decl
-      /* Don't update call from same body alias to the real function.  */
-      || (decl && cgraph_get_node (decl) == cgraph_get_node (e->callee->decl)))
+      || decl == e->callee->decl)
     return e->call_stmt;
 
 #ifdef ENABLE_CHECKING