From patchwork Tue Aug 23 18:08:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gab Charette X-Patchwork-Id: 111165 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4A3E2B6F68 for ; Wed, 24 Aug 2011 04:08:47 +1000 (EST) Received: (qmail 13060 invoked by alias); 23 Aug 2011 18:08:45 -0000 Received: (qmail 13052 invoked by uid 22791); 23 Aug 2011 18:08:44 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 18:08:30 +0000 Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id p7NI8SEF004539; Tue, 23 Aug 2011 11:08:29 -0700 Received: from gchare.mtv.corp.google.com (gchare.mtv.corp.google.com [172.18.111.122]) by hpaq14.eem.corp.google.com with ESMTP id p7NI8QI8001793; Tue, 23 Aug 2011 11:08:27 -0700 Received: by gchare.mtv.corp.google.com (Postfix, from userid 138564) id 604EC1C127A; Tue, 23 Aug 2011 11:08:26 -0700 (PDT) To: reply@codereview.appspotmail.com, crowl@google.com, dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: [pph] Remove fixed FIXME in p4eabi.h (issue4939045) Message-Id: <20110823180826.604EC1C127A@gchare.mtv.corp.google.com> Date: Tue, 23 Aug 2011 11:08:26 -0700 (PDT) From: gchare@google.com (Gabriel Charette) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This memory problem was probably due to the big line_table being created with the incorrect code before. This test now passes and this FIXME was irrelevant, removed it. Trivial patch, already discussed with Diego, committed to pph. 2011-08-23 Gabriel Charette * g++.dg/pph/p4eabi1.h: Remove fixed FIXME. --- This patch is available for review at http://codereview.appspot.com/4939045 diff --git a/gcc/testsuite/g++.dg/pph/p4eabi1.h b/gcc/testsuite/g++.dg/pph/p4eabi1.h index 781de86..8c949ea 100644 --- a/gcc/testsuite/g++.dg/pph/p4eabi1.h +++ b/gcc/testsuite/g++.dg/pph/p4eabi1.h @@ -1,5 +1,4 @@ // { dg-options "-w -fpermissive" } -// FIXME pph - Enabling PPH for this file causes memory problems in cc1plus. // c1eabi1.h c1eabi1.pph #ifndef C4EABI1_H