From patchwork Thu Jul 28 23:18:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lawrence Crowl X-Patchwork-Id: 107314 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E0418B6F69 for ; Fri, 29 Jul 2011 09:18:45 +1000 (EST) Received: (qmail 25974 invoked by alias); 28 Jul 2011 23:18:43 -0000 Received: (qmail 25966 invoked by uid 22791); 28 Jul 2011 23:18:43 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jul 2011 23:18:27 +0000 Received: from hpaq1.eem.corp.google.com (hpaq1.eem.corp.google.com [172.25.149.1]) by smtp-out.google.com with ESMTP id p6SNIQ3g027203; Thu, 28 Jul 2011 16:18:26 -0700 Received: from jade.mtv.corp.google.com (jade.mtv.corp.google.com [172.18.110.116]) by hpaq1.eem.corp.google.com with ESMTP id p6SNIMOV017888; Thu, 28 Jul 2011 16:18:24 -0700 Received: by jade.mtv.corp.google.com (Postfix, from userid 21482) id EA2E42225F1; Thu, 28 Jul 2011 16:18:16 -0700 (PDT) To: reply@codereview.appspotmail.com, dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: [pph] Put tinst_level list in forward order (issue4823059) Message-Id: <20110728231816.EA2E42225F1@jade.mtv.corp.google.com> Date: Thu, 28 Jul 2011 16:18:16 -0700 (PDT) From: crowl@google.com (Lawrence Crowl) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Place the tinst_level list in forward order. Tested on x64. --- This patch is available for review at http://codereview.appspot.com/4823059 Index: gcc/cp/ChangeLog.pph 2011-07-28 Lawrence Crowl * pt.c (pph_in_tinst_level): Put tinst_level list in forward order. Index: gcc/cp/pt.c =================================================================== --- gcc/cp/pt.c (revision 176905) +++ gcc/cp/pt.c (working copy) @@ -19738,20 +19738,24 @@ pph_dump_tinst_level (FILE *stream, stru static struct tinst_level * pph_in_tinst_level (pph_stream *stream) { + struct tinst_level *head = NULL; struct tinst_level *last = NULL; unsigned count = pph_in_uint (stream); - /* FIXME pph: This leaves the list in reverse order. Issue? */ for (; count > 0; --count) { struct tinst_level *cur = ggc_alloc_tinst_level (); - cur->next = last; + cur->next = NULL; cur->decl = pph_in_tree (stream); cur->locus = pph_in_location (stream); cur->errors = pph_in_uint (stream); cur->in_system_header_p = pph_in_uint (stream); + if (head == NULL) + head = cur; + else + last->next = cur; last = cur; } - return last; + return head; }