diff mbox

Ping Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS

Message ID 20110411212421.e7c55588.basile@starynkevitch.net
State New
Headers show

Commit Message

Basile Starynkevitch April 11, 2011, 7:24 p.m. UTC 
On Thu, 7 Apr 2011 21:43:44 +0200
Basile Starynkevitch <basile@starynkevitch.net> wrote:
> > The following tiny patch add some files to PLUGIN_HEADERS. 

###### gcc/ChangeLog entry
2011-04-11  Basile Starynkevitch  <basile@starynkevitch.net>
	* Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h 
        tree-pretty-print.h & realmpfr.h.
######

> Some more explanations about why I feel these files are badly needed
> for plugins (not only for MELT as a plugin, but for other plugins).
> 
> Pretty printing routines are very useful to help understand, debug, and
> dump any additional passes, so plugin providing passes working on
> Gimple or Tree need the gimple-pretty-print.h & tree-pretty-print.h, 
> since to call dumping or debug routines like debug_c_tree or 
> print_declaration or dump_gimple_stmt you need to include these files.
> Please consider that people coding plugins know Gimple & Tree much 
> less than GCC top level experts, and they are much more likely to 
> need debug or dumping routines!
> 
> The realmpfr.h file is needed to operate on tree or gimple containing 
> real constants. For instance, a plugin to find all occurrences (in
> Gimple) of 3.14159 need it, or also a plugin which constant-fold the
> calls to <math.h> which are not already constant folded in GCC, or a
> plugin which constant-fold calls to some other (but less standard)
> numerical library.

Ok for trunk?

Comments

Diego Novillo April 11, 2011, 7:27 p.m. UTC | #1 
On Mon, Apr 11, 2011 at 15:24, Basile Starynkevitch
<basile@starynkevitch.net> wrote:

> 2011-04-11  Basile Starynkevitch  <basile@starynkevitch.net>
>        * Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
>        tree-pretty-print.h & realmpfr.h.

OK.


Diego.
Basile Starynkevitch April 11, 2011, 7:31 p.m. UTC | #2 
On Mon, 11 Apr 2011 15:27:15 -0400
Diego Novillo <dnovillo@google.com> wrote:

> On Mon, Apr 11, 2011 at 15:24, Basile Starynkevitch
> <basile@starynkevitch.net> wrote:
> 
> > 2011-04-11  Basile Starynkevitch  <basile@starynkevitch.net>
> >        * Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
> >        tree-pretty-print.h & realmpfr.h.
> 
> OK.

Committed revision 172275.


Thanks. I would like to also commit that same patch to gcc-4.6 for the next 4.6.1 release. Is that possible? 

Cheers.
Diego Novillo April 11, 2011, 7:34 p.m. UTC | #3 
On Mon, Apr 11, 2011 at 15:31, Basile Starynkevitch
<basile@starynkevitch.net> wrote:
> On Mon, 11 Apr 2011 15:27:15 -0400
> Diego Novillo <dnovillo@google.com> wrote:
>
>> On Mon, Apr 11, 2011 at 15:24, Basile Starynkevitch
>> <basile@starynkevitch.net> wrote:
>>
>> > 2011-04-11  Basile Starynkevitch  <basile@starynkevitch.net>
>> >        * Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
>> >        tree-pretty-print.h & realmpfr.h.
>>
>> OK.
>
> Committed revision 172275.
>
>
> Thanks. I would like to also commit that same patch to gcc-4.6 for the next 4.6.1 release. Is that possible?

I'm fine with that, but I cannot approve.  You need one of our RMs to
approve that.


Diego.
diff mbox

Patch

Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in	(revision 172124)
+++ gcc/Makefile.in	(working copy)
@@ -4534,6 +4534,7 @@ 
   $(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \
   $(C_PRAGMA_H)  $(CPPLIB_H)  $(FUNCTION_H) \
   cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
+  gimple-pretty-print.h tree-pretty-print.h realmpfr.h \
   $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
 
 # generate the 'build fragment' b-header-vars