From patchwork Tue Feb 15 19:41:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Kargl X-Patchwork-Id: 83286 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 86C13B70A7 for ; Wed, 16 Feb 2011 06:41:33 +1100 (EST) Received: (qmail 26206 invoked by alias); 15 Feb 2011 19:41:31 -0000 Received: (qmail 26127 invoked by uid 22791); 15 Feb 2011 19:41:30 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Feb 2011 19:41:26 +0000 Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.4/8.14.4) with ESMTP id p1FJfOAe004766; Tue, 15 Feb 2011 11:41:24 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.4/8.14.4/Submit) id p1FJfOiA004765; Tue, 15 Feb 2011 11:41:24 -0800 (PST) (envelope-from sgk) Date: Tue, 15 Feb 2011 11:41:24 -0800 From: Steve Kargl To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [Committed] PR fortran/47633 -- fix off-by-one. Message-ID: <20110215194124.GA4716@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Tobias has reviewed and OK the patch in the PR audit trail. For the record, here is the diff. 2011-02-15 Steven G. Kargl PR fortran/47633 . simplify.c (gfc_simplify_compiler_version): Fix off-by-one issue. Index: simplify.c =================================================================== --- simplify.c (revision 170194) +++ simplify.c (working copy) @@ -6844,9 +6844,9 @@ gfc_simplify_compiler_version (void) char *buffer; size_t len; - len = strlen ("GCC version ") + strlen (version_string) + 1; - buffer = (char*) alloca (len); - snprintf (buffer, len, "GCC version %s", version_string); + len = strlen ("GCC version ") + strlen (version_string); + buffer = XALLOCAVEC (char, len + 1); + snprintf (buffer, len + 1, "GCC version %s", version_string); return gfc_get_character_expr (gfc_default_character_kind, &gfc_current_locus, buffer, len); }