From patchwork Tue Sep 21 19:07:46 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikael Morin X-Patchwork-Id: 65371 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id BB4E0B70D4 for ; Wed, 22 Sep 2010 05:09:07 +1000 (EST) Received: (qmail 11662 invoked by alias); 21 Sep 2010 19:09:05 -0000 Received: (qmail 11643 invoked by uid 22791); 21 Sep 2010 19:09:04 -0000 X-SWARE-Spam-Status: No, hits=1.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_JMF_BL, SPF_NEUTRAL, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp24.services.sfr.fr (HELO smtp24.services.sfr.fr) (93.17.128.82) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Sep 2010 19:08:57 +0000 Received: from filter.sfr.fr (localhost [127.0.0.1]) by msfrf2409.sfr.fr (SMTP Server) with ESMTP id DF3D27000097; Tue, 21 Sep 2010 21:08:55 +0200 (CEST) Received: from gimli.local (40.183.72-86.rev.gaoland.net [86.72.183.40]) by msfrf2409.sfr.fr (SMTP Server) with ESMTP id B76A57000090; Tue, 21 Sep 2010 21:08:55 +0200 (CEST) X-SFR-UUID: 20100921190855751.B76A57000090@msfrf2409.sfr.fr From: Mikael Morin To: fortran@gcc.gnu.org Subject: Re: [Patch, fortran] [5/5] PR 45648: Inline transpose part 2: Do dependency analysis in case of transpose optimization. Date: Tue, 21 Sep 2010 21:07:46 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.0-STABLE; KDE/4.5.1; amd64; ; ) Cc: Paul Richard Thomas , patches References: <20100920222130.27269.49914@gimli.local> <201009211807.28488.mikael.morin@sfr.fr> In-Reply-To: <201009211807.28488.mikael.morin@sfr.fr> MIME-Version: 1.0 Message-Id: <201009212107.46503.mikael.morin@sfr.fr> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Tuesday 21 September 2010 18:07:28 Mikael Morin wrote: > On Tuesday 21 September 2010 16:05:33 Paul Richard Thomas wrote: > > Mikael, > > > > The complete patch and the testcase are OK for trunk. Please commit > > the whole lot in one go. > > Will do. > Thanks for the reviews. > > Mikael Committed at revision 164494. For the assert concern, I added the following, just in case someone has a temporary brain failure one day. /* Set the new lower bound. */ diff --git a/trans-array.c b/trans-array.c index 1bb4429..310a42b 100644 --- a/trans-array.c +++ b/trans-array.c @@ -5535,6 +5535,8 @@ gfc_conv_expr_descriptor (gfc_se * se, gfc_expr * expr, gf for (dim = 0; dim < ndim; dim++) if (info->dim[dim] == n) break; + + /* loop exited early: the DIM being looked for has been found. */ gcc_assert (dim < ndim);