diff mbox series

genemit: Print file+line in the "Splitting with" message

Message ID 1abb1af2913b31ece951c44700b51a1fcab8075a.1567797611.git.segher@kernel.crashing.org
State New
Headers show
Series genemit: Print file+line in the "Splitting with" message | expand

Commit Message

Segher Boessenkool Sept. 6, 2019, 7:25 p.m. UTC
It's tiresome to have to look in insn-emit.c to see where some split
came from, so let's print that info to the dump file as well.  But
don't print the full path, just the basename, for greater readability.

Testing on powerpc64-linux {-m32,-m64}.  Is this okay for trunk if that
succeeds?


Segher


2019-09-06  Segher Boessenkool  <segher@kernel.crashing.org>

	* genemit.c (gen_split): Print the filename and line number where the
	splitter (or peephole2) was defined, to the dump file.

---
 gcc/genemit.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Jeff Law Sept. 8, 2019, 7:55 p.m. UTC | #1
On 9/6/19 1:25 PM, Segher Boessenkool wrote:
> It's tiresome to have to look in insn-emit.c to see where some split
> came from, so let's print that info to the dump file as well.  But
> don't print the full path, just the basename, for greater readability.
> 
> Testing on powerpc64-linux {-m32,-m64}.  Is this okay for trunk if that
> succeeds?
> 
> 
> Segher
> 
> 
> 2019-09-06  Segher Boessenkool  <segher@kernel.crashing.org>
> 
> 	* genemit.c (gen_split): Print the filename and line number where the
> 	splitter (or peephole2) was defined, to the dump file.
OK
jeff
diff mbox series

Patch

diff --git a/gcc/genemit.c b/gcc/genemit.c
index 3ff8197..4d7011c 100644
--- a/gcc/genemit.c
+++ b/gcc/genemit.c
@@ -609,9 +609,14 @@  gen_split (md_rtx_info *info)
   if (GET_CODE (split) == DEFINE_PEEPHOLE2)
     output_peephole2_scratches (split);
 
+  const char *fn = info->loc.filename;
+  for (const char *p = fn; *p; p++)
+    if (*p == '/')
+      fn = p + 1;
+
   printf ("  if (dump_file)\n");
-  printf ("    fprintf (dump_file, \"Splitting with gen_%s_%d\\n\");\n",
-	  name, info->index);
+  printf ("    fprintf (dump_file, \"Splitting with gen_%s_%d (%s:%d)\\n\");\n",
+	  name, info->index, fn, info->loc.lineno);
 
   printf ("  start_sequence ();\n");