diff mbox series

testsuite/arm: Factorize and increase coverage in mve-sub_1.c

Message ID 1619523128-14792-3-git-send-email-christophe.lyon@linaro.org
State New
Headers show
Series testsuite/arm: Factorize and increase coverage in mve-sub_1.c | expand

Commit Message

Christophe Lyon April 27, 2021, 11:32 a.m. UTC 
Use a template macro to factorize the existing test functions.

This patch also adds a version to check subtraction with __fp16 type.

2021-04-26  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/testsuite/
	* gcc.target/arm/simd/mve-vsub_1.c: Factorize and add __fp16 test.
---
 gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c | 60 +++++++++-----------------
 1 file changed, 21 insertions(+), 39 deletions(-)

Comments

Christophe Lyon May 10, 2021, 11:22 a.m. UTC | #1 
Ping?

On Tue, 27 Apr 2021 at 13:32, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> Use a template macro to factorize the existing test functions.
>
> This patch also adds a version to check subtraction with __fp16 type.
>
> 2021-04-26  Christophe Lyon  <christophe.lyon@linaro.org>
>
>         gcc/testsuite/
>         * gcc.target/arm/simd/mve-vsub_1.c: Factorize and add __fp16 test.
> ---
>  gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c | 60 +++++++++-----------------
>  1 file changed, 21 insertions(+), 39 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> index 842e5c6..5a6c345 100644
> --- a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> +++ b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> @@ -5,60 +5,42 @@
>
>  #include <stdint.h>
>
> -void test_vsub_i32 (int32_t * dest, int32_t * a, int32_t * b) {
> -  int i;
> -  for (i=0; i<4; i++) {
> -    dest[i] = a[i] - b[i];
> -  }
> +#define FUNC(SIGN, TYPE, BITS, NB, OP, NAME)                           \
> +  void test_ ## NAME ##_ ## SIGN ## BITS ## x ## NB (TYPE##BITS##_t * __restrict__ dest, \
> +                                                    TYPE##BITS##_t *a, TYPE##BITS##_t *b) { \
> +    int i;                                                             \
> +    for (i=0; i<NB; i++) {                                             \
> +      dest[i] = a[i] OP b[i];                                          \
> +    }                                                                  \
>  }
>
> -void test_vsub_i32_u (uint32_t * dest, uint32_t * a, uint32_t * b) {
> -  int i;
> -  for (i=0; i<4; i++) {
> -    dest[i] = a[i] - b[i];
> -  }
> -}
> +/* 128-bit vectors.  */
> +FUNC(s, int, 32, 4, -, vsub)
> +FUNC(u, uint, 32, 4, -, vsub)
> +FUNC(s, int, 16, 8, -, vsub)
> +FUNC(u, uint, 16, 8, -, vsub)
> +FUNC(s, int, 8, 16, -, vsub)
> +FUNC(u, uint, 8, 16, -, vsub)
>
>  /* { dg-final { scan-assembler-times {vsub\.i32\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
> -
> -void test_vsub_i16 (int16_t * dest, int16_t * a, int16_t * b) {
> -  int i;
> -  for (i=0; i<8; i++) {
> -    dest[i] = a[i] - b[i];
> -  }
> -}
> -
> -void test_vsub_i16_u (uint16_t * dest, uint16_t * a, uint16_t * b) {
> -  int i;
> -  for (i=0; i<8; i++) {
> -    dest[i] = a[i] - b[i];
> -  }
> -}
> -
>  /* { dg-final { scan-assembler-times {vsub\.i16\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
> +/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
>
> -void test_vsub_i8 (int8_t * dest, int8_t * a, int8_t * b) {
> -  int i;
> -  for (i=0; i<16; i++) {
> -    dest[i] = a[i] - b[i];
> -  }
> -}
> -
> -void test_vsub_i8_u (uint8_t * dest, uint8_t * a, uint8_t * b) {
> +void test_vsub_f32 (float * dest, float * a, float * b) {
>    int i;
> -  for (i=0; i<16; i++) {
> +  for (i=0; i<4; i++) {
>      dest[i] = a[i] - b[i];
>    }
>  }
> +/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
>
> -/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
>
> -void test_vsub_f32 (float * dest, float * a, float * b) {
> +void test_vsub_f16 (__fp16 * dest, __fp16 * a, __fp16 * b) {
>    int i;
> -  for (i=0; i<4; i++) {
> +  for (i=0; i<8; i++) {
>      dest[i] = a[i] - b[i];
>    }
>  }
>
> -/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
> +/* { dg-final { scan-assembler-times {vsub\.f16\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
>
> --
> 2.7.4
>
Christophe Lyon May 17, 2021, 9:53 a.m. UTC | #2 
ping?

On Mon, 10 May 2021 at 13:22, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> Ping?
>
> On Tue, 27 Apr 2021 at 13:32, Christophe Lyon
> <christophe.lyon@linaro.org> wrote:
> >
> > Use a template macro to factorize the existing test functions.
> >
> > This patch also adds a version to check subtraction with __fp16 type.
> >
> > 2021-04-26  Christophe Lyon  <christophe.lyon@linaro.org>
> >
> >         gcc/testsuite/
> >         * gcc.target/arm/simd/mve-vsub_1.c: Factorize and add __fp16 test.
> > ---
> >  gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c | 60 +++++++++-----------------
> >  1 file changed, 21 insertions(+), 39 deletions(-)
> >
> > diff --git a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> > index 842e5c6..5a6c345 100644
> > --- a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> > +++ b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> > @@ -5,60 +5,42 @@
> >
> >  #include <stdint.h>
> >
> > -void test_vsub_i32 (int32_t * dest, int32_t * a, int32_t * b) {
> > -  int i;
> > -  for (i=0; i<4; i++) {
> > -    dest[i] = a[i] - b[i];
> > -  }
> > +#define FUNC(SIGN, TYPE, BITS, NB, OP, NAME)                           \
> > +  void test_ ## NAME ##_ ## SIGN ## BITS ## x ## NB (TYPE##BITS##_t * __restrict__ dest, \
> > +                                                    TYPE##BITS##_t *a, TYPE##BITS##_t *b) { \
> > +    int i;                                                             \
> > +    for (i=0; i<NB; i++) {                                             \
> > +      dest[i] = a[i] OP b[i];                                          \
> > +    }                                                                  \
> >  }
> >
> > -void test_vsub_i32_u (uint32_t * dest, uint32_t * a, uint32_t * b) {
> > -  int i;
> > -  for (i=0; i<4; i++) {
> > -    dest[i] = a[i] - b[i];
> > -  }
> > -}
> > +/* 128-bit vectors.  */
> > +FUNC(s, int, 32, 4, -, vsub)
> > +FUNC(u, uint, 32, 4, -, vsub)
> > +FUNC(s, int, 16, 8, -, vsub)
> > +FUNC(u, uint, 16, 8, -, vsub)
> > +FUNC(s, int, 8, 16, -, vsub)
> > +FUNC(u, uint, 8, 16, -, vsub)
> >
> >  /* { dg-final { scan-assembler-times {vsub\.i32\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
> > -
> > -void test_vsub_i16 (int16_t * dest, int16_t * a, int16_t * b) {
> > -  int i;
> > -  for (i=0; i<8; i++) {
> > -    dest[i] = a[i] - b[i];
> > -  }
> > -}
> > -
> > -void test_vsub_i16_u (uint16_t * dest, uint16_t * a, uint16_t * b) {
> > -  int i;
> > -  for (i=0; i<8; i++) {
> > -    dest[i] = a[i] - b[i];
> > -  }
> > -}
> > -
> >  /* { dg-final { scan-assembler-times {vsub\.i16\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
> > +/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
> >
> > -void test_vsub_i8 (int8_t * dest, int8_t * a, int8_t * b) {
> > -  int i;
> > -  for (i=0; i<16; i++) {
> > -    dest[i] = a[i] - b[i];
> > -  }
> > -}
> > -
> > -void test_vsub_i8_u (uint8_t * dest, uint8_t * a, uint8_t * b) {
> > +void test_vsub_f32 (float * dest, float * a, float * b) {
> >    int i;
> > -  for (i=0; i<16; i++) {
> > +  for (i=0; i<4; i++) {
> >      dest[i] = a[i] - b[i];
> >    }
> >  }
> > +/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
> >
> > -/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
> >
> > -void test_vsub_f32 (float * dest, float * a, float * b) {
> > +void test_vsub_f16 (__fp16 * dest, __fp16 * a, __fp16 * b) {
> >    int i;
> > -  for (i=0; i<4; i++) {
> > +  for (i=0; i<8; i++) {
> >      dest[i] = a[i] - b[i];
> >    }
> >  }
> >
> > -/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
> > +/* { dg-final { scan-assembler-times {vsub\.f16\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
> >
> > --
> > 2.7.4
> >
Kyrylo Tkachov May 17, 2021, 10:27 a.m. UTC | #3 
> -----Original Message-----
> From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of
> Christophe Lyon via Gcc-patches
> Sent: 17 May 2021 10:54
> To: gcc Patches <gcc-patches@gcc.gnu.org>
> Subject: Re: [PATCH] testsuite/arm: Factorize and increase coverage in mve-
> sub_1.c
> 
> ping?
> 
> On Mon, 10 May 2021 at 13:22, Christophe Lyon
> <christophe.lyon@linaro.org> wrote:
> >
> > Ping?
> >
> > On Tue, 27 Apr 2021 at 13:32, Christophe Lyon
> > <christophe.lyon@linaro.org> wrote:
> > >
> > > Use a template macro to factorize the existing test functions.
> > >
> > > This patch also adds a version to check subtraction with __fp16 type.
> > >

Ok.
Thanks,
Kyrill

> > > 2021-04-26  Christophe Lyon  <christophe.lyon@linaro.org>
> > >
> > >         gcc/testsuite/
> > >         * gcc.target/arm/simd/mve-vsub_1.c: Factorize and add __fp16 test.
> > > ---
> > >  gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c | 60 +++++++++--------
> ---------
> > >  1 file changed, 21 insertions(+), 39 deletions(-)
> > >
> > > diff --git a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> > > index 842e5c6..5a6c345 100644
> > > --- a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> > > +++ b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
> > > @@ -5,60 +5,42 @@
> > >
> > >  #include <stdint.h>
> > >
> > > -void test_vsub_i32 (int32_t * dest, int32_t * a, int32_t * b) {
> > > -  int i;
> > > -  for (i=0; i<4; i++) {
> > > -    dest[i] = a[i] - b[i];
> > > -  }
> > > +#define FUNC(SIGN, TYPE, BITS, NB, OP, NAME)                           \
> > > +  void test_ ## NAME ##_ ## SIGN ## BITS ## x ## NB (TYPE##BITS##_t *
> __restrict__ dest, \
> > > +                                                    TYPE##BITS##_t *a, TYPE##BITS##_t *b) { \
> > > +    int i;                                                             \
> > > +    for (i=0; i<NB; i++) {                                             \
> > > +      dest[i] = a[i] OP b[i];                                          \
> > > +    }                                                                  \
> > >  }
> > >
> > > -void test_vsub_i32_u (uint32_t * dest, uint32_t * a, uint32_t * b) {
> > > -  int i;
> > > -  for (i=0; i<4; i++) {
> > > -    dest[i] = a[i] - b[i];
> > > -  }
> > > -}
> > > +/* 128-bit vectors.  */
> > > +FUNC(s, int, 32, 4, -, vsub)
> > > +FUNC(u, uint, 32, 4, -, vsub)
> > > +FUNC(s, int, 16, 8, -, vsub)
> > > +FUNC(u, uint, 16, 8, -, vsub)
> > > +FUNC(s, int, 8, 16, -, vsub)
> > > +FUNC(u, uint, 8, 16, -, vsub)
> > >
> > >  /* { dg-final { scan-assembler-times {vsub\.i32\tq[0-9]+, q[0-9]+, q[0-9]+}
> 2 } } */
> > > -
> > > -void test_vsub_i16 (int16_t * dest, int16_t * a, int16_t * b) {
> > > -  int i;
> > > -  for (i=0; i<8; i++) {
> > > -    dest[i] = a[i] - b[i];
> > > -  }
> > > -}
> > > -
> > > -void test_vsub_i16_u (uint16_t * dest, uint16_t * a, uint16_t * b) {
> > > -  int i;
> > > -  for (i=0; i<8; i++) {
> > > -    dest[i] = a[i] - b[i];
> > > -  }
> > > -}
> > > -
> > >  /* { dg-final { scan-assembler-times {vsub\.i16\tq[0-9]+, q[0-9]+, q[0-9]+}
> 2 } } */
> > > +/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+}
> 2 } } */
> > >
> > > -void test_vsub_i8 (int8_t * dest, int8_t * a, int8_t * b) {
> > > -  int i;
> > > -  for (i=0; i<16; i++) {
> > > -    dest[i] = a[i] - b[i];
> > > -  }
> > > -}
> > > -
> > > -void test_vsub_i8_u (uint8_t * dest, uint8_t * a, uint8_t * b) {
> > > +void test_vsub_f32 (float * dest, float * a, float * b) {
> > >    int i;
> > > -  for (i=0; i<16; i++) {
> > > +  for (i=0; i<4; i++) {
> > >      dest[i] = a[i] - b[i];
> > >    }
> > >  }
> > > +/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-
> 9]+} 1 } } */
> > >
> > > -/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+}
> 2 } } */
> > >
> > > -void test_vsub_f32 (float * dest, float * a, float * b) {
> > > +void test_vsub_f16 (__fp16 * dest, __fp16 * a, __fp16 * b) {
> > >    int i;
> > > -  for (i=0; i<4; i++) {
> > > +  for (i=0; i<8; i++) {
> > >      dest[i] = a[i] - b[i];
> > >    }
> > >  }
> > >
> > > -/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-9]+}
> 1 } } */
> > > +/* { dg-final { scan-assembler-times {vsub\.f16\tq[0-9]+, q[0-9]+, q[0-
> 9]+} 1 } } */
> > >
> > > --
> > > 2.7.4
> > >
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
index 842e5c6..5a6c345 100644
--- a/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
+++ b/gcc/testsuite/gcc.target/arm/simd/mve-vsub_1.c
@@ -5,60 +5,42 @@ 
 
 #include <stdint.h>
 
-void test_vsub_i32 (int32_t * dest, int32_t * a, int32_t * b) {
-  int i;
-  for (i=0; i<4; i++) {
-    dest[i] = a[i] - b[i];
-  }
+#define FUNC(SIGN, TYPE, BITS, NB, OP, NAME)				\
+  void test_ ## NAME ##_ ## SIGN ## BITS ## x ## NB (TYPE##BITS##_t * __restrict__ dest, \
+						     TYPE##BITS##_t *a, TYPE##BITS##_t *b) { \
+    int i;								\
+    for (i=0; i<NB; i++) {						\
+      dest[i] = a[i] OP b[i];						\
+    }									\
 }
 
-void test_vsub_i32_u (uint32_t * dest, uint32_t * a, uint32_t * b) {
-  int i;
-  for (i=0; i<4; i++) {
-    dest[i] = a[i] - b[i];
-  }
-}
+/* 128-bit vectors.  */
+FUNC(s, int, 32, 4, -, vsub)
+FUNC(u, uint, 32, 4, -, vsub)
+FUNC(s, int, 16, 8, -, vsub)
+FUNC(u, uint, 16, 8, -, vsub)
+FUNC(s, int, 8, 16, -, vsub)
+FUNC(u, uint, 8, 16, -, vsub)
 
 /* { dg-final { scan-assembler-times {vsub\.i32\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
-
-void test_vsub_i16 (int16_t * dest, int16_t * a, int16_t * b) {
-  int i;
-  for (i=0; i<8; i++) {
-    dest[i] = a[i] - b[i];
-  }
-}
-
-void test_vsub_i16_u (uint16_t * dest, uint16_t * a, uint16_t * b) {
-  int i;
-  for (i=0; i<8; i++) {
-    dest[i] = a[i] - b[i];
-  }
-}
-
 /* { dg-final { scan-assembler-times {vsub\.i16\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
+/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
 
-void test_vsub_i8 (int8_t * dest, int8_t * a, int8_t * b) {
-  int i;
-  for (i=0; i<16; i++) {
-    dest[i] = a[i] - b[i];
-  }
-}
-
-void test_vsub_i8_u (uint8_t * dest, uint8_t * a, uint8_t * b) {
+void test_vsub_f32 (float * dest, float * a, float * b) {
   int i;
-  for (i=0; i<16; i++) {
+  for (i=0; i<4; i++) {
     dest[i] = a[i] - b[i];
   }
 }
+/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
 
-/* { dg-final { scan-assembler-times {vsub\.i8\tq[0-9]+, q[0-9]+, q[0-9]+} 2 } } */
 
-void test_vsub_f32 (float * dest, float * a, float * b) {
+void test_vsub_f16 (__fp16 * dest, __fp16 * a, __fp16 * b) {
   int i;
-  for (i=0; i<4; i++) {
+  for (i=0; i<8; i++) {
     dest[i] = a[i] - b[i];
   }
 }
 
-/* { dg-final { scan-assembler-times {vsub\.f32\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */
+/* { dg-final { scan-assembler-times {vsub\.f16\tq[0-9]+, q[0-9]+, q[0-9]+} 1 } } */