From patchwork Tue Apr 27 11:32:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 1470656 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=B67By/Z5; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FV03j0BFhz9t14 for ; Tue, 27 Apr 2021 21:32:17 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 823A43944821; Tue, 27 Apr 2021 11:32:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 823A43944821 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1619523134; bh=675A6y3YHo5OXut7YAnvodc/iERbQc381jr5HYXu8jo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=B67By/Z5oxf2jyKvZhyirj89uSg9lONiEX6los/xkq98jfryTuc2W/7ezmCC9XOiC k+rJaZFG1aPke7mzcZaGA3zswvw3bAKXNiTChNDaeUG+1krBGrAA+R9mYsyoU5jS3L IMYWG70sC6uzJRFcmGC3LziilCOSO+Ax14okEd0M= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 7CEFC3989C88 for ; Tue, 27 Apr 2021 11:32:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7CEFC3989C88 Received: by mail-wm1-x32a.google.com with SMTP id o21-20020a1c4d150000b029012e52898006so6672469wmh.0 for ; Tue, 27 Apr 2021 04:32:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=675A6y3YHo5OXut7YAnvodc/iERbQc381jr5HYXu8jo=; b=aDGeMLdH2gML64iWRlVcoE2tJA5kLMjKwCX7HbTmw2loZsCO5lwF0UqktCdXWoncdT xsKVz2U1/9cAweoKFgPFVb4e4xB1RA/WLdgJIEwIiAlm+RWCcFunGylq9zT1w7yVxX4r 0T090pxNZjvEzNwaeQn4lFZ+gLfuQlQwGfE0QeTCYtKURDox64N/SuUj8K288fZ5HiuL 2oJsj8FhYCYzMGTwodsVGYc/+Jft3QfaTWUOqQFFFQ94PjRoVDw8d9r3zw56m4xrP8R9 BJJaQjDf7Hp+89fpDE2M+PHX7rrJ8svgWcd9WP3S8Ryw1DnMU2tNgZMZdiVomJzgfKDS tp3w== X-Gm-Message-State: AOAM533Sfpoeyw2Bb7bCR3r1qEeWj/50bice1WbKHqjAu5z6BGyEbouy 1jbbfnI32vvpm0E8HR1NOBa7rfvWIGg41A== X-Google-Smtp-Source: ABdhPJwX1m6k72pyQxaf1fr+U48Pa0ktkZD303VqwFbj0g908j+43ZYpOSbT/3ZthiGh4mShiC+mmg== X-Received: by 2002:a7b:c017:: with SMTP id c23mr3754847wmb.175.1619523130107; Tue, 27 Apr 2021 04:32:10 -0700 (PDT) Received: from localhost.localdomain (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id f4sm3688550wrz.33.2021.04.27.04.32.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Apr 2021 04:32:09 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH] gcc/genflags.c: Improve error message Date: Tue, 27 Apr 2021 11:32:05 +0000 Message-Id: <1619523128-14792-1-git-send-email-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christophe Lyon via Gcc-patches From: Christophe Lyon Reply-To: Christophe Lyon Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" When an iterator cannot be expanded, it is helpful to see the expanded name which is causing problems. It would be better to also print the current iterator value (which couldn't match), but I couldn't find how. 2021-03-01 Christophe Lyon gcc/ * genflags.c (gen_insn): Print failed expansion string. --- gcc/genflags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/genflags.c b/gcc/genflags.c index f65b16a..a154b85 100644 --- a/gcc/genflags.c +++ b/gcc/genflags.c @@ -152,7 +152,7 @@ gen_insn (md_rtx_info *info) lt = strchr (name, '<'); if (lt && strchr (lt + 1, '>')) { - error_at (info->loc, "unresolved iterator"); + error_at (info->loc, "unresolved iterator in %s", name); return; } @@ -160,7 +160,7 @@ gen_insn (md_rtx_info *info) if (lt || gt) { error_at (info->loc, "unmatched angle brackets, likely " - "an error in iterator syntax"); + "an error in iterator syntax in %s", name); return; }