From patchwork Thu Apr 22 13:32:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 1469206 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=k8yznXDd; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FQyz02ZFsz9sWH for ; Thu, 22 Apr 2021 23:32:41 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F3BB3943417; Thu, 22 Apr 2021 13:32:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F3BB3943417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1619098358; bh=fgC35LDLqnE8a34fmyRcfg+AdQdAuuMa4pmZhriYgOo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=k8yznXDdnkMyi6fzZMxwWYi08ot5NHJWFTPb7Zh5Uv6+k3bzJ21Mo3RqmMi4192tG /IGgjS29GktfD27QX3IApwPLs4wSDFSx3kCrcPJlAhl9niLAaUaSzhCKvUs1ahQN91 aTnAqYZo7qE1Wseq+CUOfBegR2C3IDRWvRGi5Kbc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 95799389683D for ; Thu, 22 Apr 2021 13:32:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 95799389683D Received: by mail-wm1-x330.google.com with SMTP id i21-20020a05600c3555b029012eae2af5d4so3258613wmq.4 for ; Thu, 22 Apr 2021 06:32:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=fgC35LDLqnE8a34fmyRcfg+AdQdAuuMa4pmZhriYgOo=; b=ud1dyri8arrwT6w7dFP70qQxs7chfBC1Bp3a1fOudNfixu0tv8ZfNKh4pXpXLGQiTT vtwuQp7dxkYpmK/UIW9Zcx1Tvo0yZT+8SnjgOMVRv3PSjggJApkub4of9+oZ4MNmGy4P B6CSv98n3dB7CkXUFRiuxlN2wucDCOqNl+yn4M3E/LO0hnnvGgdC2dCeh137eccJ3urG WFUeh9jdLOk4v2+szFj9SmzsloYMfrH5opsZks3CTYOqy4gGThFSr/9+PzdWdey2JHw2 DwI6/Csm0UVByemL9hTQsEleF7JU2FWOrqabBNAF0DT8ey8Mu1dKEg5Ha8wluGZeHUBE t4ow== X-Gm-Message-State: AOAM530jSiIB4PYNQ1W5MGMQwpglw7s43L09rdcrKiqzCl/nbDRQmKrT Y70jAiJ2VZpx2t4DSHhjAivdQbY7FFLmdEJM X-Google-Smtp-Source: ABdhPJxEAfbdqDvZpQtUr0DhY4DUydShhbQ3gqFxE6HlTzc8j2SPdqEw9tM6Z+mrvHsDxLqRIEg5Qg== X-Received: by 2002:a05:600c:49a4:: with SMTP id h36mr66374wmp.102.1619098353206; Thu, 22 Apr 2021 06:32:33 -0700 (PDT) Received: from localhost.localdomain (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id x2sm4047498wrg.31.2021.04.22.06.32.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Apr 2021 06:32:32 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH] testsuite/arm: Improve unsigned-float.c Date: Thu, 22 Apr 2021 13:32:32 +0000 Message-Id: <1619098352-14431-1-git-send-email-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christophe Lyon via Gcc-patches From: Christophe Lyon Reply-To: Christophe Lyon Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" The test requires an FPU, so use -march=armv7-a+fp -mfpu=auto instead of -march=armv7-a. We also remove dg-require-effective-target arm_fp_ok, but keep dg-add-options arm_fp: this enables the test to pass on arm-eabi configured with default cpu/fpu/mode. dg-require-effective-target arm_fp_ok fails on such a configuration for lack of FPU, since dg-options are not taken into account by dg-require-effective-target. Add -march=armv7-a+fp -mfpu=auto is sufficient for arm_fp options to be acceptable. This enables the test to pass on all the arm-eabi configurations I'm testing, as well as arm-linux-gnueabi when forcing -march=armv5t. 2021-04-22 Christophe Lyon gcc/testsuite/ * gcc.target/arm/unsigned-float.c: Remove arm_fp_ok, adjust dg-options. --- gcc/testsuite/gcc.target/arm/unsigned-float.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.target/arm/unsigned-float.c b/gcc/testsuite/gcc.target/arm/unsigned-float.c index ad589d9..ea3abc7 100644 --- a/gcc/testsuite/gcc.target/arm/unsigned-float.c +++ b/gcc/testsuite/gcc.target/arm/unsigned-float.c @@ -1,8 +1,8 @@ /* { dg-do compile } */ -/* { dg-require-effective-target arm_fp_ok } */ -/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */ /* { dg-skip-if "-mpure-code supports M-profile only" { *-*-* } { "-mpure-code" } } */ -/* { dg-options "-march=armv7-a -O1" } */ +/* { dg-options "-march=armv7-a+fp -mfpu=auto -O1" } */ +/* Do not require arm_ok effective target to avoid skipping on arm-eabi with + default configure options. */ /* { dg-add-options arm_fp } */