| Message ID | 1587383022-30441-1-git-send-email-christophe.lyon@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] testsuite: Handle --save-temps in schedule-cleanups | expand |
On 20 April 2020 13:43:42 CEST, Christophe Lyon via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: >Some tests use --save-temps, but schedule-cleanups strictly matches >-save-temps, so we leave many temporary files after validation. >Instead of fixing every offending testcase, it's simpler and >future-proof to make schedule-cleanups handle both --save-temps and >-save-temps. LGTM. > >2020-04-20 Christophe Lyon <christophe.lyon@linaro.org> > > gcc/testsuite/ > * lib/gcc-dg.exp (schedule-cleanups): Accept --save-temps. >--- > gcc/testsuite/lib/gcc-dg.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/gcc/testsuite/lib/gcc-dg.exp >b/gcc/testsuite/lib/gcc-dg.exp >index cccd3ce..27cc7c1 100644 >--- a/gcc/testsuite/lib/gcc-dg.exp >+++ b/gcc/testsuite/lib/gcc-dg.exp >@@ -171,7 +171,7 @@ proc schedule-cleanups { opts } { > verbose "dg-keep-saved-temps ${keep_saved_temps_suffixes}" 2 > } > # -save-temps -> cleanup-saved-temps() >- if [regexp -- {(^|\s+)-save-temps(\s+|$)} $opts] { >+ if [regexp -- {(^|\s+)-?-save-temps(\s+|$)} $opts] { > verbose "Cleanup -save-temps seen" 4 > if [info exists keep_saved_temps_suffixes] { > append finalcode "cleanup-saved-temps >${keep_saved_temps_suffixes}\n"
On Mon, 2020-04-20 at 11:43 +0000, Christophe Lyon via Gcc-patches wrote: > Some tests use --save-temps, but schedule-cleanups strictly matches > -save-temps, so we leave many temporary files after validation. > Instead of fixing every offending testcase, it's simpler and > future-proof to make schedule-cleanups handle both --save-temps and > -save-temps. > > 2020-04-20 Christophe Lyon <christophe.lyon@linaro.org> > > gcc/testsuite/ > * lib/gcc-dg.exp (schedule-cleanups): Accept --save-temps. OK Jeff >
diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp index cccd3ce..27cc7c1 100644 --- a/gcc/testsuite/lib/gcc-dg.exp +++ b/gcc/testsuite/lib/gcc-dg.exp @@ -171,7 +171,7 @@ proc schedule-cleanups { opts } { verbose "dg-keep-saved-temps ${keep_saved_temps_suffixes}" 2 } # -save-temps -> cleanup-saved-temps() - if [regexp -- {(^|\s+)-save-temps(\s+|$)} $opts] { + if [regexp -- {(^|\s+)-?-save-temps(\s+|$)} $opts] { verbose "Cleanup -save-temps seen" 4 if [info exists keep_saved_temps_suffixes] { append finalcode "cleanup-saved-temps ${keep_saved_temps_suffixes}\n"