From patchwork Tue May 2 07:56:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 757421 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wHDBy5qqfz9s3T for ; Tue, 2 May 2017 17:56:42 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="D5fR6KV/"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; q=dns; s= default; b=jh9tAYhDsZJgcGRGxtvPCVhBsNePhnR1qOGznO8BMF34Th/TTQrm9 16eVKmurRuVLVrT626H6vzD62HoshnJi0WCz6sQBqnR+utZlVweO7TSNgI1+kCxc BO2K5m3TT0PbIEoxDA9HbkVoZm/Sc6hRZDEAzZkN9bHVVhtwf3byNI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; s=default; bh=hvFgBcLyutJgAjxDGAUU/dtOrgk=; b=D5fR6KV/IH3HUz+9Pkq+tWDY0bia 2KjkaldFKfGI9bVUN73W/yLKM8AfdZ3OnbgzWHLcP69UUDz5IBBsATifaVObztOy 0cGr4fk8Tk+9G8y0bGmyttLsLmMszm8kATe733KQrD8hGA/ZBkGan2LiIBKOy5uf w5eSkd2VyrI/LKU= Received: (qmail 32153 invoked by alias); 2 May 2017 07:56:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32126 invoked by uid 89); 2 May 2017 07:56:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, URIBL_SBL autolearn=ham version=3.3.2 spammy=HTo:U*schwab, H*Ad:D*edu.cn, H*Ad:D*cn, H*r:eYou X-HELO: stu.xidian.edu.cn Received: from stumail.xidian.edu.cn (HELO stu.xidian.edu.cn) (202.117.112.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 02 May 2017 07:56:28 +0000 Received: from xry111-laptop (xry111-laptop [10.170.53.45]) by stu.xidian.edu.cn (eYou MTA v8.1.0) with ESMTP id 68cb9acb6f429f6bb780096d27a082d5 for ; Tue, 02 May 2017 16:06:57 +0800 X-Eyou-Smtpauth: ryxi@stu.xidian.edu.cn Message-ID: <1493711779.24177.3.camel@stu.xidian.edu.cn> Subject: Re: [PATCH v2] Destroy arguments for _Cilk_spawn calling in the child (PR 80038) From: Xi Ruoyao To: Andreas Schwab , Jeff Law Cc: ryxi@stu.xidian.edu.cn, Richard Biener , Jan Hubicka , GCC Patches , Florent Hivert Date: Tue, 02 May 2017 15:56:19 +0800 In-Reply-To: References: <1490968216.19897.36.camel@stu.xidian.edu.cn> <92541d5b-cf85-94de-4a81-29cb2a757ade@redhat.com> <1491573766.1782.7.camel@stu.xidian.edu.cn> <1492153217.3945.9.camel@stu.xidian.edu.cn> <1492217060.991.1.camel@stu.xidian.edu.cn> <60054e41-6470-40c7-ed8b-7b05862f5969@redhat.com> <1493389879.9757.3.camel@stu.xidian.edu.cn> <88b9a2be-3cea-7acb-90b2-30265b901902@redhat.com> <1493436025.969.10.camel@stu.xidian.edu.cn> Mime-Version: 1.0 X-Eyou-Sender: On 2017-05-02 09:16 +0200, Andreas Schwab wrote: > This could be related to --enable-checking=release: > > In file included from ../../gcc/c-family/c-common.h:26:0, >                  from ../../gcc/c-family/cilk.c:28: > ../../gcc/c-family/cilk.c: In function 'bool cilk_set_spawn_marker(location_t, tree)': > ../../gcc/tree.h:901:42: error: 'tree_check2' was not declared in this scope >                  CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag) >                                           ^ > ../../gcc/c-family/cilk.c:113:9: note: in expansion of macro 'EXPR_CILK_SPAWN' >          EXPR_CILK_SPAWN (fcall) = 1; >          ^ > ../../gcc/tree.h:901:42: error: 'tree_check2' was not declared in this scope >                  CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag) >                                           ^ > ../../gcc/c-family/cilk.c:115:9: note: in expansion of macro 'EXPR_CILK_SPAWN' >          EXPR_CILK_SPAWN (TREE_OPERAND (fcall, 1)) = 1; >          ^ > > Andreas. > Sorry T_T.  I've made a stupid mistake in tree.h. Let's apply following patch, and alert the RM when backporting r247446. 2017-05-02 Xi Ruoyao * tree.h (EXPR_CILK_SPAWN): Use macro TREE_CHECK2 instead of function tree_check2. ---  gcc/tree.h | 4 ++--  1 file changed, 2 insertions(+), 2 deletions(-) --  2.7.1 diff --git a/gcc/tree.h b/gcc/tree.h index 3bca90a..fdaa7af 100644 --- a/gcc/tree.h +++ b/gcc/tree.h @@ -897,8 +897,8 @@ extern void omp_clause_range_check_failed (const_tree, const char *, int,  /* If this is true, we should insert a __cilk_detach call just before     this function call.  */  #define EXPR_CILK_SPAWN(NODE) \ -  (tree_check2 (NODE, __FILE__, __LINE__, __FUNCTION__, \ -                CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag) +  (TREE_CHECK2 (NODE, CALL_EXPR, \ +                AGGR_INIT_EXPR)->base.u.bits.unsigned_flag)    /* In a RESULT_DECL, PARM_DECL and VAR_DECL, means that it is     passed by invisible reference (and the TREE_TYPE is a pointer to the true