[PR,target/79752] fix rs6000 power9 peephole2 for udiv/umod

Message ID	1488319320.5475.10.camel@linux.vnet.ibm.com
State	New
Headers	show Return-Path: <gcc-patches-return-449295-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:cc:date:content-type:mime-version :content-transfer-encoding:message-id; q=dns; s=default; b=ETe+A Li7ycgebq0fIblhtb/AdsYwtWUjUmArqRaqQGDBDgQm8teddUHwT8PcWdSffI90Y +msw7kllqfITe62G9s7pMsdyU/CsjRVt8Pw0mJ5bQYUxEL9RqV3Yx+X9G39Kbn5W megiX8UYnPmIpSmZR00BBcy6T4Fn46Bs56sCoc= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org Gateway: Authorized Use Only! Violators will be prosecuted for <gcc-patches@gcc.gnu.org> from <acsawdey@linux.vnet.ibm.com>; Tue, 28 Feb 2017 15:02:04 -0700 Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 28 Feb 2017 15:02:02 -0700 Subject: [PATCH][PR target/79752] fix rs6000 power9 peephole2 for udiv/umod From: Aaron Sawdey <acsawdey@linux.vnet.ibm.com> To: gcc-patches@gcc.gnu.org Cc: Segher Boessenkool <segher@kernel.crashing.org>, Bill Schmidt <wschmidt@linux.vnet.ibm.com>, meissner@gcc.gnu.org Date: Tue, 28 Feb 2017 16:02:00 -0600 Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <1488319320.5475.10.camel@linux.vnet.ibm.com>

Message ID

1488319320.5475.10.camel@linux.vnet.ibm.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender
	:subject:from:to:cc:date:content-type:mime-version
	:content-transfer-encoding:message-id; q=dns; s=default; b=ETe+A
	Li7ycgebq0fIblhtb/AdsYwtWUjUmArqRaqQGDBDgQm8teddUHwT8PcWdSffI90Y
	+msw7kllqfITe62G9s7pMsdyU/CsjRVt8Pw0mJ5bQYUxEL9RqV3Yx+X9G39Kbn5W
	megiX8UYnPmIpSmZR00BBcy6T4Fn46Bs56sCoc=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
Subject: [PATCH][PR target/79752] fix rs6000 power9 peephole2 for udiv/umod
From: Aaron Sawdey <acsawdey@linux.vnet.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	Bill Schmidt	 <wschmidt@linux.vnet.ibm.com>, meissner@gcc.gnu.org
Date: Tue, 28 Feb 2017 16:02:00 -0600
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <1488319320.5475.10.camel@linux.vnet.ibm.com>

Commit Message

Aaron Sawdey Feb. 28, 2017, 10:02 p.m. UTC

This showed up in power9 code for __divkf3 software float support and
caused a divd to be emitted where we needed a divdu. OK for trunk if
bootstrap/regtest passes?


2017-02-28  Aaron Sawdey  <acsawdey@linux.vnet.ibm.com>

	PR target/79752
	* config/rs6000/rs6000.md (peephole2 for udiv/umod): Should emit
	udiv rather than div since input pattern is unsigned.

Comments

Segher Boessenkool March 1, 2017, 12:37 a.m. UTC | #1

On Tue, Feb 28, 2017 at 04:02:00PM -0600, Aaron Sawdey wrote:
> This showed up in power9 code for __divkf3 software float support and
> caused a divd to be emitted where we needed a divdu. OK for trunk if
> bootstrap/regtest passes?

Yes, certainly.  Thanks!


Segher


> --- ../trunk/gcc/config/rs6000/rs6000.md        (revision 245787)
> +++ ../trunk/gcc/config/rs6000/rs6000.md        (working copy)
> @@ -3161,7 +3161,7 @@
>     && ! reg_mentioned_p (operands[3], operands[1])
>     && ! reg_mentioned_p (operands[3], operands[2])"
>    [(set (match_dup 0)
> -       (div:GPR (match_dup 1)
> +       (udiv:GPR (match_dup 1)
>                  (match_dup 2)))
>     (set (match_dup 3)
>         (mult:GPR (match_dup 0)
> 
> 2017-02-28  Aaron Sawdey  <acsawdey@linux.vnet.ibm.com>
> 
> 	PR target/79752
> 	* config/rs6000/rs6000.md (peephole2 for udiv/umod): Should emit
> 	udiv rather than div since input pattern is unsigned.

Index: ../trunk/gcc/config/rs6000/rs6000.md
===================================================================
--- ../trunk/gcc/config/rs6000/rs6000.md        (revision 245787)
+++ ../trunk/gcc/config/rs6000/rs6000.md        (working copy)
@@ -3161,7 +3161,7 @@ 
    && ! reg_mentioned_p (operands[3], operands[1])
    && ! reg_mentioned_p (operands[3], operands[2])"
   [(set (match_dup 0)
-       (div:GPR (match_dup 1)
+       (udiv:GPR (match_dup 1)
                 (match_dup 2)))
    (set (match_dup 3)
        (mult:GPR (match_dup 0)

[PR,target/79752] fix rs6000 power9 peephole2 for udiv/umod

Commit Message

Comments

Patch