diff mbox

[4/4,ARC] Fix compilation issue in pr71872.

Message ID 1479291481-24225-5-git-send-email-claziss@synopsys.com
State New
Headers show

Commit Message

Claudiu Zissulescu Nov. 16, 2016, 10:18 a.m. UTC 
gcc/
2016-07-21  Claudiu Zissulescu  <claziss@synopsys.com>

	* config/arc/arc.c (arc_ccfsm_post_advance): Handle return
	instruction type.
---
 gcc/config/arc/arc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Andrew Burgess Nov. 17, 2016, 11 a.m. UTC | #1 
* Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com> [2016-11-16 11:18:01 +0100]:

> gcc/
> 2016-07-21  Claudiu Zissulescu  <claziss@synopsys.com>
> 
> 	* config/arc/arc.c (arc_ccfsm_post_advance): Handle return
> 	instruction type.

Looks fine.

Thanks,
Andrew



> ---
>  gcc/config/arc/arc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c
> index 7eadb3c..a033dd0 100644
> --- a/gcc/config/arc/arc.c
> +++ b/gcc/config/arc/arc.c
> @@ -4251,9 +4251,8 @@ arc_ccfsm_post_advance (rtx_insn *insn, struct arc_ccfsm *state)
>  	   && GET_CODE (PATTERN (insn)) != ADDR_VEC
>  	   && GET_CODE (PATTERN (insn)) != ADDR_DIFF_VEC
>  	   && ((type = get_attr_type (insn)) == TYPE_BRANCH
> -	       || (type == TYPE_UNCOND_BRANCH
> -		   /* ??? Maybe should also handle TYPE_RETURN here,
> -		      but we don't have a testcase for that.  */
> +	       || ((type == TYPE_UNCOND_BRANCH
> +		    || type == TYPE_RETURN)
>  		   && ARC_CCFSM_BRANCH_DELETED_P (state))))
>      {
>        if (ARC_CCFSM_BRANCH_DELETED_P (state))
> -- 
> 1.9.1
>
Claudiu Zissulescu Nov. 17, 2016, 1:45 p.m. UTC | #2 
> Looks fine.
> 
> Thanks,
> Andrew
> 
Committed, thank you for your review,
Claudiu
diff mbox

Patch

diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c
index 7eadb3c..a033dd0 100644
--- a/gcc/config/arc/arc.c
+++ b/gcc/config/arc/arc.c
@@ -4251,9 +4251,8 @@  arc_ccfsm_post_advance (rtx_insn *insn, struct arc_ccfsm *state)
 	   && GET_CODE (PATTERN (insn)) != ADDR_VEC
 	   && GET_CODE (PATTERN (insn)) != ADDR_DIFF_VEC
 	   && ((type = get_attr_type (insn)) == TYPE_BRANCH
-	       || (type == TYPE_UNCOND_BRANCH
-		   /* ??? Maybe should also handle TYPE_RETURN here,
-		      but we don't have a testcase for that.  */
+	       || ((type == TYPE_UNCOND_BRANCH
+		    || type == TYPE_RETURN)
 		   && ARC_CCFSM_BRANCH_DELETED_P (state))))
     {
       if (ARC_CCFSM_BRANCH_DELETED_P (state))