From patchwork Sun Jan 3 06:36:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 562147 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3743E140556 for ; Sun, 3 Jan 2016 17:36:35 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=TsHG6Aq1; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id; q=dns; s=default; b=SPHY5TxvuUOBEY4 FfcH9+cihtgR+Qh8tJLeuSc6qoej9dw/Ew29E+xgwOApDkBADVkX1TfQSg8Kfxw8 oRg7voYDC6Xx5Ps9saLhLoXtlGiTHf5g8d+zUD0sViuqvhSsGa+qNkgwe1Psf+fq SvADmu5ubZIpKe1oJcT3F3Vfl9ok= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id; s=default; bh=cip3Vc69mdBun0s9ZRruH CPf++c=; b=TsHG6Aq1wBlHVzPQ8+BzaL0mJmEjnDc+XHCIQUEfbeGsFm0sFMoJ3 f9ywlTzKJPe4l4byyd0w9k19DTLRQMWpX2it6HZ3Ib7R723PbpHzwS3TpoW5FUjL o8ovzn062JZI21CNM/EvhXLAyM0a4/g2UssHl7b71chDer6M85S5KE= Received: (qmail 32913 invoked by alias); 3 Jan 2016 06:36:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32827 invoked by uid 89); 3 Jan 2016 06:36:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS, UNSUBSCRIBE_BODY autolearn=no version=3.3.2 spammy=2016-01-03, xmalloc, 767, Hx-languages-length:761 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 03 Jan 2016 06:36:18 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 9F69533FE7D for ; Sun, 3 Jan 2016 06:36:13 +0000 (UTC) From: Mike Frysinger To: gcc-patches@gcc.gnu.org Subject: [PATCH] libiberty: dupargv: rewrite to use xstrdup Date: Sun, 3 Jan 2016 01:36:10 -0500 Message-Id: <1451802970-18103-1-git-send-email-vapier@gentoo.org> This func is basically open coding the xstrdup function, so gut it and use it directly. 2016-01-03 Mike Frysinger * argv.c (dupargv): Replace strlen/xmalloc/strcpy with xstrdup. --- libiberty/argv.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libiberty/argv.c b/libiberty/argv.c index f2727e8..5c3dd70 100644 --- a/libiberty/argv.c +++ b/libiberty/argv.c @@ -76,11 +76,7 @@ dupargv (char **argv) /* the strings */ for (argc = 0; argv[argc] != NULL; argc++) - { - int len = strlen (argv[argc]); - copy[argc] = (char *) xmalloc (len + 1); - strcpy (copy[argc], argv[argc]); - } + copy[argc] = xstrdup (argv[argc]); copy[argc] = NULL; return copy; }