diff mbox

Fix enum operands exchange in ipa-inline.c

Message ID 1421045253350.63190@caviumnetworks.com
State New
Headers show

Commit Message

Hurugalawadi, Naveen Jan. 12, 2015, 6:47 a.m. UTC 
Hi,

Please find attached the patch that fixes swap of operands to enum
in ipa-inline.c.

This issue popped up when running dhrystone with -fdump-ipa-all.

Please review the patch and let me know it its okay?

Regression tested on aarch64-elf.

Thanks,
Naveen

Comments

Hurugalawadi, Naveen Jan. 12, 2015, 6:58 a.m. UTC | #1 
Hi,

Sorry, Had forgot the ChangeLog.

ChangeLog
2015-01-12  Naveen H.S  <Naveen.Hurugalawadi@caviumnetworks.com>

        * ipa-inline.c (inline_small_functions): Swap the operands in
        enum.

Thanks,
Naveen
Richard Biener Jan. 12, 2015, 9:18 a.m. UTC | #2 
On Mon, Jan 12, 2015 at 7:58 AM, Hurugalawadi, Naveen
<Naveen.Hurugalawadi@caviumnetworks.com> wrote:
> Hi,
>
> Sorry, Had forgot the ChangeLog.

Ok, but please properly wrap the long lines, put '? gimple_...' on a new
one.

Thanks,
Richard.

> ChangeLog
> 2015-01-12  Naveen H.S  <Naveen.Hurugalawadi@caviumnetworks.com>
>
>         * ipa-inline.c (inline_small_functions): Swap the operands in
>         enum.
>
> Thanks,
> Naveen
diff mbox

Patch

--- a/gcc/ipa-inline.c	2015-01-12 11:04:53.627735210 +0530
+++ b/gcc/ipa-inline.c	2015-01-12 11:05:08.395735041 +0530
@@ -1730,10 +1730,10 @@  inline_small_functions (void)
 		   " to be inlined into %s/%i in %s:%i\n"
 		   " Estimated badness is %f, frequency %.2f.\n",
 		   edge->caller->name (), edge->caller->order,
-		   edge->call_stmt ? "unknown"
-		   : gimple_filename ((const_gimple) edge->call_stmt),
-		   edge->call_stmt ? -1
-		   : gimple_lineno ((const_gimple) edge->call_stmt),
+		   edge->call_stmt ? gimple_filename ((const_gimple) edge->call_stmt)
+		   : "unknown",
+		   edge->call_stmt ? gimple_lineno ((const_gimple) edge->call_stmt)
+		   : -1,
 		   badness.to_double (),
 		   edge->frequency / (double)CGRAPH_FREQ_BASE);
 	  if (edge->count)