| Message ID | 1410717072-21031-2-git-send-email-andi@firstfloor.org |
|---|---|
| State | New |
| Headers | show |
On Sep 14, 2014, at 10:51 AM, Andi Kleen <andi@firstfloor.org> wrote: > From: Andi Kleen <ak@linux.intel.com> > > Add some simple test cases for noreorder behaving like > -fno-toplevel-reorder and -fno-toplevel-reorder still working. > Unfortunately there's no easy way to check for output order in DG, > so we just check for existence. I thought some of these would span lines…. foo.*bar could check foo on a line before bar? /* { dg-final { scan-assembler "section.*foo" } } */ int foo (int a) { static const int ar[] = { &&l1 - &&l1, &&l2 - &&l1 }; void *p = &&l1 + ar[a]; goto *p; l1: return 1; l2: return 2; } Yup, works just fine. Some might say it isn’t a feature, but we have no plans to fix it.
diff --git a/gcc/testsuite/gcc.dg/noreorder.c b/gcc/testsuite/gcc.dg/noreorder.c new file mode 100644 index 0000000..1559465 --- /dev/null +++ b/gcc/testsuite/gcc.dg/noreorder.c @@ -0,0 +1,24 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +extern void f2(int); + +__attribute__((no_reorder, noinline)) static int foobar(void) +{ + f2(1); +} + +static int barbar(void) +{ + f2(2); +} + +int bozo(void) +{ + f2(3); + foobar(); +} + +/* { dg-final { scan-assembler "foobar" } } */ +/* { dg-final { scan-assembler "bozo" } } */ +/* { dg-final { scan-assembler-not "barbar" } } */ diff --git a/gcc/testsuite/gcc.dg/noreorder2.c b/gcc/testsuite/gcc.dg/noreorder2.c new file mode 100644 index 0000000..558361b --- /dev/null +++ b/gcc/testsuite/gcc.dg/noreorder2.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fno-toplevel-reorder" } */ + +__attribute__((no_reorder)) int foobar; + +static int barbar; +int bozo; + +/* { dg-final { scan-assembler "foobar" } } */ +/* { dg-final { scan-assembler "bozo" } } */ +/* { dg-final { scan-assembler "barbar" } } */ diff --git a/gcc/testsuite/gcc.dg/noreorder3.c b/gcc/testsuite/gcc.dg/noreorder3.c new file mode 100644 index 0000000..a0b637f --- /dev/null +++ b/gcc/testsuite/gcc.dg/noreorder3.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +__attribute__((no_reorder)) int foobar; +static int barbar; +int bozo; + +/* { dg-final { scan-assembler "foobar" } } */ +/* { dg-final { scan-assembler "bozo" } } */ +/* { dg-final { scan-assembler-not "barbar" } } */
From: Andi Kleen <ak@linux.intel.com> Add some simple test cases for noreorder behaving like -fno-toplevel-reorder and -fno-toplevel-reorder still working. Unfortunately there's no easy way to check for output order in DG, so we just check for existence. gcc/testsuite/: 2014-09-14 Andi Kleen <ak@linux.intel.com> * gcc.dg/noreorder.c: New test. * gcc.dg/noreorder2.c: New test. * gcc.dg/noreorder3.c: New test. --- gcc/testsuite/gcc.dg/noreorder.c | 24 ++++++++++++++++++++++++ gcc/testsuite/gcc.dg/noreorder2.c | 11 +++++++++++ gcc/testsuite/gcc.dg/noreorder3.c | 10 ++++++++++ 3 files changed, 45 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/noreorder.c create mode 100644 gcc/testsuite/gcc.dg/noreorder2.c create mode 100644 gcc/testsuite/gcc.dg/noreorder3.c