From patchwork Mon Aug 12 12:58:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 266521 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 91EC62C00A1 for ; Mon, 12 Aug 2013 22:58:54 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; q=dns; s=default; b=Kme4NoDWQwfKvJA5 A1Yo44FoZzrmwA8LN6178GJacnNxU2bQoYNeqxLuPUcgVpkIFVGJ7pRBFAvcmdF7 pM8gSm5sk6i1BWt+LCfxbloenVtplBhvtWUagyngux4WgOH1iZ/3t/6VSft+3uFq Zr5TxN54fFkKlyXxuBgOHZWNP1I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; s=default; bh=LGd2BPlP0MeiOByqiwayH/ pnleg=; b=Y3PtzIE3L99cdeF5529xXrS4NAPgDTP+KAYaYegJROlR7/fmdmkbXS cir/oQoCD9k+vJ9lE2IexHmjWSXG4a5ltTxIEhcPSIHc/Yw3MS3ELqdAlPd3d2FK deGNfRANsRPXbp/9enlL1yk82t3mPS+DYMaYhURzusqqCeOJZ6YH4= Received: (qmail 1686 invoked by alias); 12 Aug 2013 12:58:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 1671 invoked by uid 89); 12 Aug 2013 12:58:47 -0000 X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 12 Aug 2013 12:58:46 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 12 Aug 2013 13:58:43 +0100 Received: from e106375-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Mon, 12 Aug 2013 13:58:42 +0100 From: James Greenhalgh To: gcc-patches@gcc.gnu.org Cc: marcus.shawcroft@arm.com, ramana.radhakrishnan@arm.com Subject: [AArch64] Fix name of macros called in the vdup_lane Neon intrinsics Date: Mon, 12 Aug 2013 13:58:34 +0100 Message-Id: <1376312314-9812-1-git-send-email-james.greenhalgh@arm.com> In-Reply-To: <5204B05B.7010806@arm.com> References: <5204B05B.7010806@arm.com> MIME-Version: 1.0 X-MC-Unique: 113081213584400301 X-Virus-Found: No Ugh. Typos in arm_neon.h macro names mean that scalar intrinsics end up calling macros which don't exist. So wherever I have written vget_laneq I should have written vgetq_lane. This gets fixed by: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00535.html which I was testing at the same time. But, yuck that shouldn't have happened. Tested on aarch64-none-elf with no regressions. OK? Thanks, James --- gcc/ * config/aarch64/arm_none.h (vdup_lane_<8,16,32,64>): Fix macro call. diff --git a/gcc/config/aarch64/arm_neon.h b/gcc/config/aarch64/arm_neon.h index 73a5400..4a480fb 100644 --- a/gcc/config/aarch64/arm_neon.h +++ b/gcc/config/aarch64/arm_neon.h @@ -19780,49 +19780,49 @@ vcvtpq_u64_f64 (float64x2_t __a) __extension__ static __inline int8x1_t __attribute__ ((__always_inline__)) vdupb_lane_s8 (int8x16_t a, int const b) { - return __aarch64_vget_laneq_s8 (a, b); + return __aarch64_vgetq_lane_s8 (a, b); } __extension__ static __inline uint8x1_t __attribute__ ((__always_inline__)) vdupb_lane_u8 (uint8x16_t a, int const b) { - return __aarch64_vget_laneq_u8 (a, b); + return __aarch64_vgetq_lane_u8 (a, b); } __extension__ static __inline int16x1_t __attribute__ ((__always_inline__)) vduph_lane_s16 (int16x8_t a, int const b) { - return __aarch64_vget_laneq_s16 (a, b); + return __aarch64_vgetq_lane_s16 (a, b); } __extension__ static __inline uint16x1_t __attribute__ ((__always_inline__)) vduph_lane_u16 (uint16x8_t a, int const b) { - return __aarch64_vget_laneq_u16 (a, b); + return __aarch64_vgetq_lane_u16 (a, b); } __extension__ static __inline int32x1_t __attribute__ ((__always_inline__)) vdups_lane_s32 (int32x4_t a, int const b) { - return __aarch64_vget_laneq_s32 (a, b); + return __aarch64_vgetq_lane_s32 (a, b); } __extension__ static __inline uint32x1_t __attribute__ ((__always_inline__)) vdups_lane_u32 (uint32x4_t a, int const b) { - return __aarch64_vget_laneq_u32 (a, b); + return __aarch64_vgetq_lane_u32 (a, b); } __extension__ static __inline int64x1_t __attribute__ ((__always_inline__)) vdupd_lane_s64 (int64x2_t a, int const b) { - return __aarch64_vget_laneq_s64 (a, b); + return __aarch64_vgetq_lane_s64 (a, b); } __extension__ static __inline uint64x1_t __attribute__ ((__always_inline__)) vdupd_lane_u64 (uint64x2_t a, int const b) { - return __aarch64_vget_laneq_s64 (a, b); + return __aarch64_vgetq_lane_u64 (a, b); } /* vld1 */