From patchwork Fri May 20 22:11:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 96672 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 98A22B71A2 for ; Sat, 21 May 2011 08:12:11 +1000 (EST) Received: (qmail 4014 invoked by alias); 20 May 2011 22:12:09 -0000 Received: (qmail 4006 invoked by uid 22791); 20 May 2011 22:12:09 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 May 2011 22:11:55 +0000 Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) by smtp-out.google.com with ESMTP id p4KMBsGI005781 for ; Fri, 20 May 2011 15:11:54 -0700 Received: from vws20 (vws20.prod.google.com [10.241.21.148]) by wpaz9.hot.corp.google.com with ESMTP id p4KMAGmc000982 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 20 May 2011 15:11:53 -0700 Received: by vws20 with SMTP id 20so2976202vws.4 for ; Fri, 20 May 2011 15:11:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.147.85.18 with SMTP id n18mr69936yal.25.1305929513091; Fri, 20 May 2011 15:11:53 -0700 (PDT) Reply-To: crowl@google.com, dnovillo@google.com, gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com X-Google-Appengine-App-Id: codereview Message-ID: <000e0cd34f7ebac5b704a3bc68c3@google.com> Date: Fri, 20 May 2011 22:11:53 +0000 Subject: Re: [pph] Various Tree Fields (issue4550064) From: dnovillo@google.com To: crowl@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c#newcode251 gcc/cp/pph-streamer-in.c:251: { +static VEC(qualified_typedef_usage_t,gc) * +pph_stream_read_qual_use_vec (pph_stream *stream) +{ This breaks bootstrap. This function is never used. I think you meant to call it from the TEMPLATE_INFO handler, right? Does this look like the right fix? ; /* FIXME pph: already handled? */ http://codereview.appspot.com/4550064/ diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c index d40fd17..c426466 100644 --- a/gcc/cp/pph-streamer-in.c +++ b/gcc/cp/pph-streamer-in.c @@ -904,7 +904,7 @@ pph_stream_read_tree (struct lto_input_block *ib ATTRIBUTE_UNUSED, else if (TREE_CODE (expr) == TEMPLATE_INFO) { TI_TYPEDEFS_NEEDING_ACCESS_CHECKING (expr) - = pph_stream_read_tree_vec (stream); + = pph_stream_read_qual_use_vec (stream); } else if (TREE_CODE (expr) == TREE_LIST)