Message ID | 20220221211747.53681-1-pc@us.ibm.com |
---|---|
Headers | show |
Series | rs6000: Move g++.dg powerpc tests to g++.target | expand |
On Mon, Feb 21, 2022 at 03:17:44PM -0600, Paul A. Clarke wrote: > Some tests in g++.dg are target-specific for powerpc. Move those to > g++.target/powerpc. Update the DejaGnu directives as needed, since > the target restriction is perhaps no longer needed when residing in the > target-specific powerpc subdirectory. Not "perhaps" :-) More specifically, powerpc.exp has # Exit immediately if this isn't a PowerPC target. if {![istarget powerpc*-*-*] } then { return } so anything run from that driver does not have to test for powerpc separately anymore. Segher
On Tue, Feb 22, 2022 at 12:28:56PM -0600, Segher Boessenkool wrote: > On Mon, Feb 21, 2022 at 03:17:44PM -0600, Paul A. Clarke wrote: > > Some tests in g++.dg are target-specific for powerpc. Move those to > > g++.target/powerpc. Update the DejaGnu directives as needed, since > > the target restriction is perhaps no longer needed when residing in the > > target-specific powerpc subdirectory. > > Not "perhaps" :-) More specifically, powerpc.exp has > > # Exit immediately if this isn't a PowerPC target. > if {![istarget powerpc*-*-*] } then { > return > } > > so anything run from that driver does not have to test for powerpc > separately anymore. The context for "perhaps" is for cases like: // { dg-do compile { target powerpc*-*-darwin* } } and // { dg-do compile { target { powerpc*-*-linux* } } } where the target is still needed, albeit without the "powerpc" restriction itself. PC