| Message ID | 20241201184707.45135-1-W_Armin@gmx.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi/wmi: Stop directing users to outdated LWN article | expand |
Thanks! Acked-by: Ivan Hu <ivan.hu@canonical.com> On 2024/12/2 02:47, Armin Wolf wrote: > The old LWN article about WMI drivers is outdated. Modern WMI drivers > should use the new bus-based API instead which is documented under > https://docs.kernel.org/wmi/driver-development-guide.html. > > Signed-off-by: Armin Wolf <W_Armin@gmx.de> > --- > src/acpi/wmi/wmi.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c > index 7dfb855f..73af40f0 100644 > --- a/src/acpi/wmi/wmi.c > +++ b/src/acpi/wmi/wmi.c > @@ -402,13 +402,9 @@ static void wmi_no_known_driver( > if (!wmi_advice_given) { > wmi_advice_given = true; > fwts_log_advice(fw, > - "A WMI driver probably needs to be written for this " > - "WMI event. It can checked for using: wmi_has_guid(\"%s\"). " > - "One can install a notify handler using " > - "wmi_install_notify_handler(\"%s\", handler, NULL). " > - "http://lwn.net/Articles/391230 describes how to write an " > - "appropriate driver.", > - guid_str, guid_str); > + "A WMI driver probably needs to be written for this WMI event. " > + "https://docs.kernel.org/wmi/driver-development-guide.html describes how " > + "to write an appropriate WMI driver."); > } > } > > -- > 2.39.5 > >
diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c index 7dfb855f..73af40f0 100644 --- a/src/acpi/wmi/wmi.c +++ b/src/acpi/wmi/wmi.c @@ -402,13 +402,9 @@ static void wmi_no_known_driver( if (!wmi_advice_given) { wmi_advice_given = true; fwts_log_advice(fw, - "A WMI driver probably needs to be written for this " - "WMI event. It can checked for using: wmi_has_guid(\"%s\"). " - "One can install a notify handler using " - "wmi_install_notify_handler(\"%s\", handler, NULL). " - "http://lwn.net/Articles/391230 describes how to write an " - "appropriate driver.", - guid_str, guid_str); + "A WMI driver probably needs to be written for this WMI event. " + "https://docs.kernel.org/wmi/driver-development-guide.html describes how " + "to write an appropriate WMI driver."); } }
The old LWN article about WMI drivers is outdated. Modern WMI drivers should use the new bus-based API instead which is documented under https://docs.kernel.org/wmi/driver-development-guide.html. Signed-off-by: Armin Wolf <W_Armin@gmx.de> --- src/acpi/wmi/wmi.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.39.5