From patchwork Fri Oct 11 10:40:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 1996302 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XQKn80NDpz1xtp for ; Sat, 12 Oct 2024 08:41:00 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1szNNM-00086C-LK; Fri, 11 Oct 2024 21:40:44 +0000 Received: from mout.gmx.net ([212.227.17.21]) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1szNNK-00085s-HJ for fwts-devel@lists.ubuntu.com; Fri, 11 Oct 2024 21:40:42 +0000 X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYeR1-1tUX1i2JPf-00Qcp0; Fri, 11 Oct 2024 23:40:13 +0200 From: Armin Wolf To: ivan.hu@canonical.com Subject: [PATCH v2 2/2] acpi/wmi: Warn if WMI GUIDs from the Windows driver samples are found Date: Fri, 11 Oct 2024 23:40:09 +0200 Message-Id: <20241011214009.28540-2-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241011214009.28540-1-W_Armin@gmx.de> References: <20241011214009.28540-1-W_Armin@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:TVVlzgEU3kR2oCKu89zgeKh+u0maV99F3+3y9HC8tujUzQSjSMM nZLfih6RF8lbz2kA+OBxQ/hkxXtANtlcDk1BWneKIj3900ZDmUSaigZfFvTI9CxU5epo3dH FbrJNcQ2zeIledN1zakQEyLsr175W8ouDcLHcJpjMSVJT9aSRUVwouv0mJaUlk+qs6AVtoH QyVkLW+CaYg2qqxA8c+tQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:RflyDO65Sjc=;1cOvKsE67tlLF89Z724uCcqXyGU ZOG/4nWJk2zQ8CHX8R6wu2pWg3Jd58E30Skd399e3CPdOp2w7uRC+H23uYlzCdX0kgBRljo8d u9PZkNONUT+0u+R4xyHEWyFwSeEWjosHxEoQno5wxd2dBBiteYnKkSU3P3k9W/eW75Z0c6ETu yo/rbBp0K18P1Z5mPNIb5cdXow06ko28tQTdjSp/bIyNSpUN8kgrV5LVwMgbhu9KhWaP5nYEt WQNksntoYTiHa5BkMybBbez5GgS6AVoewyC6ydVIe6ztRyAAZ1VvMol82+HmwXkNA46HoRsGN GOnqmTuTkgmbhWdaYsaNFANzdCG0RlO6/vpidnkQM5uFj/9Iyg4whB+l1b6IAa2ulkvhrwGz1 vui9mEVry+VQWfLLlEyic3j/nNTMRSvQwVZFSzMrErsqfpCDW8HUJJiMb4YOTI1IB5fN9Ivq3 ndznFSniLTpjcd5TQp/YKvR+L+MWY5YarteK8KAKnt7lc/9SoAZo47UmdKRDofU2CxuvGvphG dfyLLjJ+5aVWmX1l7CzMc8WtUxaiI9SY60WV+A1cnivgaZGj2YUy4Ashgo2HSounyO8WdBgty OGC5R5nWdCiucYPMX3jdTEVTr39KuK0vcmAL9l+grZ7cG2CRCUqBWl/9PBOqCf9uhHgtyms+M 6Fg2nVb2xhixE+8pgmOnLUhdHRmkZrW9twXGiDRJACIjc4lXktbsYKC8vqZPC6tTGynnpXZ4k dWYQ5BZUCgkSJM0z/3F44rMDP5msJmPID8dsNr6+vNuXpCo46RB7/EH0XKWPv4zpsZeMJeg1N r7hJeX1dUwnyLkz5tHc8XO8A== Received-SPF: pass client-ip=212.227.17.21; envelope-from=W_Armin@gmx.de; helo=mout.gmx.net X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fwts-devel@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Some manufacturers like Uniwill just blindly copy the example code from the Windows driver samples without generating new unique WMI GUIDs. This prevents WMI drivers for those WMI GUIDs from being loaded automatically since they cannot reliably identify if a WMI device with such a GUID is actually supported by them. Signed-off-by: Armin Wolf Acked-by: Ivan Hu --- Changes since v1: - use LOG_LEVEL_MEDIUM instead of LOG_LEVEL_CRITICAL --- src/acpi/wmi/wmi.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) -- 2.39.5 diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c index 7a746354..98a73d46 100644 --- a/src/acpi/wmi/wmi.c +++ b/src/acpi/wmi/wmi.c @@ -129,6 +129,25 @@ static fwts_wmi_known_guid fwts_wmi_known_guids[] = { { NULL, NULL, NULL } }; +/* + * List of WMI GUIDs used inside the Windows driver samples. + * + * Some manufacturers just blindly copy those, which prevents their WMI drivers + * from being loaded automatically since those GUIDs are not unique and cannot + * be used for reliable WMI device identification. + */ +static const char * const windows_example_wmi_guids[] = { + "ABBC0F6A-8EA1-11D1-00A0-C90629100000", + "ABBC0F6B-8EA1-11D1-00A0-C90629100000", + "ABBC0F6C-8EA1-11D1-00A0-C90629100000", + "ABBC0F6D-8EA1-11D1-00A0-C90629100000", + "ABBC0F6E-8EA1-11D1-00A0-C90629100000", + "ABBC0F6F-8EA1-11D1-00A0-C90629100000", + "ABBC0F70-8EA1-11D1-00A0-C90629100000", + "ABBC0F71-8EA1-11D1-00A0-C90629100000", + "ABBC0F72-8EA1-11D1-00A0-C90629100000" +}; + /* * WMI flag to text mappings */ @@ -341,6 +360,31 @@ static void wmi_method_exist_count( guid_str, object_name, wm_name); } +/* + * wmi_guid_copycat() + * Warn if a WMI from the Windows driver samples was found. This usually means that + * the manufacturer just blindly copied the example code without generating new + * unique WMI GUIDs. + */ +static void wmi_guid_copycat( + fwts_framework *fw, + const char *guid_str) +{ + int i; + + for (i = 0; i < FWTS_ARRAY_SIZE(windows_example_wmi_guids); i++) { + if (strcmp(guid_str, windows_example_wmi_guids[i]) == 0) { + fwts_failed(fw, LOG_LEVEL_MEDIUM, + "WMIExampleGUIDCopycat", + "GUID %s has likely been copied from the Windows driver samples, " + "this is a firmware bug that prevents WMI drivers from reliably " + "detecting such WMI devices since their GUID is not unique.", + guid_str); + return; + } + } +} + /* * wmi_no_known_driver() * grumble that the kernel does not have a known handler for this GUID @@ -462,6 +506,8 @@ static void wmi_parse_wdg_data( wmi_block_query_exist_count(fw, info, acpi_object_name, guid_str); } + wmi_guid_copycat(fw, guid_str); + if (info->instance == 0) fwts_failed(fw, LOG_LEVEL_LOW, "WMIZeroInstance", "GUID %s has zero instances", guid_str);