From patchwork Thu Feb 29 01:05:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 1906073 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TlY1c1p09z23fC for ; Thu, 29 Feb 2024 12:05:40 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rfUrc-00088F-8M; Thu, 29 Feb 2024 01:05:33 +0000 Received: from mail-bn7nam10on2069.outbound.protection.outlook.com ([40.107.92.69] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rfUrZ-000885-Ao for fwts-devel@lists.ubuntu.com; Thu, 29 Feb 2024 01:05:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SHuhJXlZ3vspOYKqivqyHC4ZwAPkyezibBBKKDjAmiPEUfoYFHtKO8ef3ASG1GS5wWUt+tKHE8n8HOZIlLQXEjHb4xUJ5lZFRpIQvp9q6q7AFIKT8Es1xRuhj3RQq0ZwMzKNDzfTuAvp6KJJZtUZz0zyFsrxQA/NO6yPJZnGZ329w7KxDYFM4ociF3/ljFWo7jZQl/KBYZ2Co1v6DUCfdTdOArPqWc8CZ50NeQfbt/lOsm/C8J6O9l+Xq2bqj21SAQn/acCoY7g9NS3eGlwCV3Xfpwik+wi1yFykDNxKcnfticAa5w5ar3I8m1VmzHtujPuWa+tcQ6KHBByAAYNM6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fm1qQLlDb2s3UuqPE2YP2LVTmjXsgLEuwtI2oEsTiAQ=; b=LNaJKXSEygoakuablgbg2RdxidjQZp8VhEm+QW4458faoKgLUxQ06BFi/N0feEK55IE9waadqHgxRBjhyeBnhzpL91p26TYWYs56r3mchg/RI9688+23JlS7QmOuYZeKCiMOdlDRReY9P+2BZq+7i4gK2DDi/B87GMKSACCoqs5Np6E+skYgr9fHKuop1cJVlhi13Emnj3Aqm6BVJZasNYLqGcP0H98lyiPnkBMwRpCRv1BPgZu3fWp8MoVlTWdJ8XGn2cqQbRH2Og4oO/Dh86roOeM699rlhEU4o/ETrByMJuCefBCHLbY9mBqm1adVwYUSTKZlkiOK3c18Irr56A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) Received: from CY5PR14CA0022.namprd14.prod.outlook.com (2603:10b6:930:2::32) by CYYPR12MB9016.namprd12.prod.outlook.com (2603:10b6:930:c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Thu, 29 Feb 2024 01:05:25 +0000 Received: from CY4PEPF0000EE32.namprd05.prod.outlook.com (2603:10b6:930:2:cafe::aa) by CY5PR14CA0022.outlook.office365.com (2603:10b6:930:2::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.29 via Frontend Transport; Thu, 29 Feb 2024 01:05:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7292.25 via Frontend Transport; Thu, 29 Feb 2024 01:05:25 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 28 Feb 2024 19:05:24 -0600 From: Mario Limonciello To: Subject: [PATCH] dmicheck: Fix mistake in previous update to 3.7 Date: Wed, 28 Feb 2024 19:05:09 -0600 Message-ID: <20240229010509.368-1-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE32:EE_|CYYPR12MB9016:EE_ X-MS-Office365-Filtering-Correlation-Id: ba0dcfe8-61b2-4919-1731-08dc38c28306 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qfT7QhOVVdhDg7G1LryGHsUIyt/tNr1ZDsj2Qui13TM+vDK6L7P9SxRnPoDxdhENOvZk0PS6Ipb/Y9/Pna4jhnTnhSTeuXJAUGkTn9xK/aZRhnDBf3++zSrC1p9uDLkIpLIDd6a6s/vD53FU6vGrewGqBr0wDj1D/92pT8HC3LrkDCFdmDXVM+LM7x3/AtZF8M5yg5An2rrP526BlxzHLggtjVFsrhSHpGnWg3XuZ46AU4GH32ukgaGr5eNJwZ6UNLlkKWHgeScXxdleMELD7tP/EJZklNVxeiZal/pLjYejCjUZA+WL+26eE4fEGbEvoTwr1kt5AS2IYTY4h/OfF3W7SadfQtaK0go5Lj7pq2PVEa1UeyrF8h+Kw2TyX0Xrg3vsk2No0vTklczmu1VKsTss+rwrg/J1xIR0SNv5xwHAkQi5zUHmGcXiyYd+3BZ4ecocEa62u871mzjAzzFD56mNm/cCweV2OH2DMLF/XAvMcb1R2A7swmAYA0xqFTzplGWga8y3yx1L4iKuIcA6VIaRmqr5EzF/qvWjgZVcyMmyIX/cNFa9tj4EcAewISREWeVIBLYimtqVJeWldxMTAUowt3rh2XfMCThzxW5IcuhZPjVf6eaky+OIZwjSBc00tTBLeAnJIXG4Dp5TlMifkWOzRgUpJtJ9LDfaxV0KDWVS+gR2/wT3SlKM2Q0NOIXtvDG+GrrWtIELIcrmivi5AY+F6Vyf8ZLHO56ftfQDmjoMekFMgcNaQLNhpUpryuzi X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 01:05:25.1699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba0dcfe8-61b2-4919-1731-08dc38c28306 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE32.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB9016 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mario Limonciello Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" For type 17 version 3.7 the length is still 0x5c. It shouldn't have been updated to 0x64. Fixes: dfc5729b ("dmicheck: update supported DMI version to 3.7") Signed-off-by: Mario Limonciello --- src/dmi/dmicheck/dmicheck.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index b7cca5e4..904c0356 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -299,8 +299,7 @@ static const fwts_dmi_type_length type_info[] = { { 17, 0x208, 0x207, 0x22 }, { 17, 0x302, 0x208, 0x28 }, { 17, 0x303, 0x302, 0x54 }, - { 17, 0x307, 0x303, 0x5c }, - { 17, MAX_VERSION, 0x307, 0x64 }, + { 17, MAX_VERSION, 0x303, 0x5c }, { 19, 0x207, 0x201, 0xf }, { 19, MAX_VERSION, 0x207, 0x1f }, { 20, 0x207, 0x201, 0x13 },