From patchwork Fri Oct 22 17:18:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1545012 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=SrW7N8tp; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HbWKj487Pz9sRR for ; Sat, 23 Oct 2021 04:19:03 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mdyBz-0006W3-MJ; Fri, 22 Oct 2021 17:18:55 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mdyBy-0006Vw-Sy for fwts-devel@lists.ubuntu.com; Fri, 22 Oct 2021 17:18:54 +0000 Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id B18763FFF2 for ; Fri, 22 Oct 2021 17:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634923134; bh=j/AKTi+UBXRJaGORQ0p7sGggExWgSTtGNGPs2SdlShI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=SrW7N8tp0aTRs+sUnNHFMXBNQYR0Qu/Meptf+rAWOmfHlmf9nZJwrVou/IJoLhIa1 uQtTA/Ru3PKpvm0yDXXXfw1Zb9Q5JEzHbT76YBrgMz0q96Sl3h3bQBnLv8aoMC4SSK u8YKuXuvOTd1gttKIz5ofz22pPHl1T3fufSy3H038sWwu5jQ37+mXuFo5zrLOgCzjh MToqxN32pk7SKAg7Bfy/mvKwPTMWwblg876mqkeM/e5FMzFWytKy4WpSS+YLS9WMzD 9KA4T+LSIDBCgWwmzs2PTX92ulWDt8U8uY9QYVLZTdkIgY/2tsW1AVVgFsO3RKIfSs MdiBcVAfEa92Q== Received: by mail-pj1-f71.google.com with SMTP id mt16-20020a17090b231000b001a1fcbadfefso955805pjb.2 for ; Fri, 22 Oct 2021 10:18:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j/AKTi+UBXRJaGORQ0p7sGggExWgSTtGNGPs2SdlShI=; b=qMB3hjkmUfMOAD6jCBGs/H5f12YPkzS/1x2mfldSljRljpt0wEvEjUCfRTNb8ax3lz TVpSrvTGnh85+DseRI+/iAmMKKF2oZR3ElY2E9gUcE+OcXOuR58pjpRo2WZs53qnGsiF QHrpmJceASsuR0529XNF/oFmBFdtBFb9tbcDO+uNDZinG2Snk1xRhdjVRYA68u6V4Sc4 Z1bekgKiyxj1aB2He6uJDbiTWr6oRCi4unMU7Yj7imSDaKsJrPB+JJl8F4jkklrHl5HZ a9exdT58Jf+agC/s9fKOHmRc7uKOlf0pMmxwjqEGauZt2gexfLCvvlzSB8uC11rka5wY POIg== X-Gm-Message-State: AOAM531aJi9s87p2fwS+NZ2qXe4SEifc0VJPbBFNviQww7VvLBMSJGlJ G5Ly9ENwC+SODEygoKX7B5vhCz7r4wQU+53gSgxC4tdXATcut3u0eGFmCF4eoCAKqPTZMeV5e9v Xokz7gRnDShUaa3z7FVlCvWmtVWIKiOieefdS/z1q X-Received: by 2002:a17:90a:62c9:: with SMTP id k9mr3464520pjs.52.1634923131902; Fri, 22 Oct 2021 10:18:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRqDb4nJJAJOpqo5UKRUgaJw2dINTVSouMA/fO7KtU9kyoGmNvNQaK3FEiTH1WiQirWxLj8A== X-Received: by 2002:a17:90a:62c9:: with SMTP id k9mr3464490pjs.52.1634923131614; Fri, 22 Oct 2021 10:18:51 -0700 (PDT) Received: from canonical.com (node-1w7jr9yebujeq5th4a1ypmgrl.ipv6.telus.net. [2001:56a:78ed:fb00::f61]) by smtp.gmail.com with ESMTPSA id f7sm6002224pfj.63.2021.10.22.10.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 10:18:51 -0700 (PDT) From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_smbios: fix loading SMBIOS table from uefi Date: Fri, 22 Oct 2021 11:18:49 -0600 Message-Id: <20211022171849.2090452-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: G Edhaya Chandran Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: G Edhaya Chandran Buglink: https://bugs.launchpad.net/bugs/1947956 In the case where SMBIOS table is loaded from /sys/firmware/dmi/tables/smbios_entry_point, the load fails due to a logical error in the if condition which is solved below: The load fails with the below logs dmicheck: Could not find any SMBIOS Table Entry Points. dmicheck: Cannot find SMBIOS30 table entry. Fixes: 8ce006f4ada ("lib: fwts_smbios: merge similar functions") Signed-off-by: Edhaya Chandran Signed-off-by: Alex Hung Reviewed-by: Sunny Wang Tested-by: Sunny Wang Signed-off-by: Edhaya Chandran Signed-off-by: Alex Hung