diff mbox series

acpi: dmar: constify a pointer argument in acpi_parse_dev_scope

Message ID 20210922101524.177193-1-colin.king@canonical.com
State Accepted
Headers show
Series acpi: dmar: constify a pointer argument in acpi_parse_dev_scope | expand

Commit Message

Colin Ian King Sept. 22, 2021, 10:15 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

One of the pointer arguments can be const, clean up a cppcheck
style warning.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/dmar/dmar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Sept. 22, 2021, 7:08 p.m. UTC | #1
On 2021-09-22 4:15 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> One of the pointer arguments can be const, clean up a cppcheck
> style warning.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/dmar/dmar.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/dmar/dmar.c b/src/acpi/dmar/dmar.c
> index 5b06c8c7..91721229 100644
> --- a/src/acpi/dmar/dmar.c
> +++ b/src/acpi/dmar/dmar.c
> @@ -190,7 +190,7 @@ error:
>  }
>  
>  static int acpi_parse_dev_scope(fwts_framework *fw,
> -	uint8_t *start, uint8_t *end, const uint16_t seg)
> +	uint8_t *start, const uint8_t *end, const uint16_t seg)
>  {
>  	while (start < end) {
>  		struct acpi_dev_scope *scope = (struct acpi_dev_scope *)start;
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Sept. 23, 2021, 3:42 a.m. UTC | #2
On 9/22/21 6:15 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> One of the pointer arguments can be const, clean up a cppcheck
> style warning.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/dmar/dmar.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/dmar/dmar.c b/src/acpi/dmar/dmar.c
> index 5b06c8c7..91721229 100644
> --- a/src/acpi/dmar/dmar.c
> +++ b/src/acpi/dmar/dmar.c
> @@ -190,7 +190,7 @@ error:
>  }
>  
>  static int acpi_parse_dev_scope(fwts_framework *fw,
> -	uint8_t *start, uint8_t *end, const uint16_t seg)
> +	uint8_t *start, const uint8_t *end, const uint16_t seg)
>  {
>  	while (start < end) {
>  		struct acpi_dev_scope *scope = (struct acpi_dev_scope *)start;
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/acpi/dmar/dmar.c b/src/acpi/dmar/dmar.c
index 5b06c8c7..91721229 100644
--- a/src/acpi/dmar/dmar.c
+++ b/src/acpi/dmar/dmar.c
@@ -190,7 +190,7 @@  error:
 }
 
 static int acpi_parse_dev_scope(fwts_framework *fw,
-	uint8_t *start, uint8_t *end, const uint16_t seg)
+	uint8_t *start, const uint8_t *end, const uint16_t seg)
 {
 	while (start < end) {
 		struct acpi_dev_scope *scope = (struct acpi_dev_scope *)start;