From patchwork Wed Sep 22 09:50:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 1531145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=PEHcq6y4; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HDtnp5jdqz9sVq for ; Wed, 22 Sep 2021 19:50:21 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mSytO-0007or-5U; Wed, 22 Sep 2021 09:50:18 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mSytM-0007ol-Qw for fwts-devel@lists.ubuntu.com; Wed, 22 Sep 2021 09:50:16 +0000 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 90D184017D; Wed, 22 Sep 2021 09:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632304216; bh=Vkm0qaPmi/p/B1c12KRUDG640UkYoUNs6Xkin5Njnzc=; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; b=PEHcq6y4xKIeYpX6y6/kr6iUohv0rTOVR2NyYYer7LKULtiDJze6hsTya691j045a ZTzXrQbdifF0/FgXdODWx/Z/fAKqxVo6EP18nHSHJHAb81Mp7RO4oQpidr1c61l3kU uJygFcYxW7rB4k+lHudaH0o90jdSSzJZQSc5xMfQ70f9+ZT+ec5gt9sjl485hag7dn +L/9uOhoAIY8RJxMUqMiwilXC2auBmANEAtmN2zk/4li6QEbGzgOjaQtabU6Eo/fvD brQU/g4OouJWs0EVbZx6chjmV/cSV+4TChnyEs4wYSV97o7ZjPwDvBx+ShcvufeVI1 m+zZ7WgX9c7NA== From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] opal: Fix a few memory leaks on asprint allocated buffers Date: Wed, 22 Sep 2021 10:50:16 +0100 Message-Id: <20210922095016.160051-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King There are a few paths where asprintf allocated buffers are not being free'd. Fix the leaks. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/opal/mem_info.c | 4 ++++ src/opal/mtd_info.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c index 03b04762..a5291e28 100644 --- a/src/opal/mem_info.c +++ b/src/opal/mem_info.c @@ -222,6 +222,7 @@ static int process_dimm( } } + free(my_path); free(my_buffer); free(namelist[i]); } @@ -308,6 +309,7 @@ static int process_mba( if (process_dimm(fw, "dimm", my_path)) { failures++; } + free(my_path); free(my_buffer); free(namelist[i]); } @@ -363,6 +365,7 @@ static int get_linux_mem_devices(fwts_framework *fw) dirent = namelist[i]; + mem_buffer = NULL; if (dirent->d_name[0] == '.' || asprintf(&mem_buffer, "%s", @@ -395,6 +398,7 @@ static int get_linux_mem_devices(fwts_framework *fw) if (process_mba(fw, "mba", mba_path)) { failures++; } + free(mba_path); free(mem_buffer); free(namelist[i]); } diff --git a/src/opal/mtd_info.c b/src/opal/mtd_info.c index 209b2566..4a00fc46 100644 --- a/src/opal/mtd_info.c +++ b/src/opal/mtd_info.c @@ -315,8 +315,8 @@ static int mtd_info_test1(fwts_framework *fw) } fwts_log_nl(fw); } - free(mtd_device_path); } + free(mtd_device_path); } free(namelist[i]);