From patchwork Tue Jul 13 06:38:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Hu X-Patchwork-Id: 1504432 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Cf1Q7Zzj; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GP9v31qzTz9sWl for ; Tue, 13 Jul 2021 16:38:22 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1m3C3e-0005w9-Ae; Tue, 13 Jul 2021 06:38:18 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1m3C3c-0005w3-7q for fwts-devel@lists.ubuntu.com; Tue, 13 Jul 2021 06:38:16 +0000 Received: from canonical.com (unknown [175.182.110.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 41E7740596 for ; Tue, 13 Jul 2021 06:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1626158296; bh=jy5yqt0jzU24tmKKFwSUaBx5xJIYi8y8aEneD4ch9qc=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Cf1Q7Zzj5netZTr2YtAwx+Ab0+HCVJFRA9qg7f07QrorgRvrx3jzUtZed4bNyflwH HrD0G2tNheJHetVnsVCuT8qUgOyL8HqjvJl8waddOo1SjPmd+wZ+Dt1zHW+Y/N+7uZ FLYC351xGWDQnyCr/GXm4zCBVBFr8P6vtTIFvb0GpuD9V9xfD+yO70hsa6449Tbcb3 AFgPmQJqreKWcJmjRhc4MIMuNho9t2Kpz60B0/G278BKjwvYZYCdeI5SkiwJ2wavfn vJ1/iqOf7bXoy7pjaTIAygUE1+P4AfUb9EZNfp08zgl7CHBrym7PmZv/+sZwf3zcSH xEjx3EdZHKyIQ== From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH][V2] uefirttime: add advice for the timezone 2047 failure (LP: #1933503) Date: Tue, 13 Jul 2021 14:38:09 +0800 Message-Id: <20210713063809.5458-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Some system firmwares do not support the timezone value EFI_UNSPECIFIED_TIMEZONE(2047) and set the value 0 directly instead of returning status EFI_INVALID_PARAMETER error. Add the advice information for the failure. Signed-off-by: Ivan Hu Acked-by: Colin Ian King Acked-by: Alex Hung --- src/uefi/uefirttime/uefirttime.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c index 9c3d6a19..786f29a2 100644 --- a/src/uefi/uefirttime/uefirttime.c +++ b/src/uefi/uefirttime/uefirttime.c @@ -417,6 +417,11 @@ static int uefirttime_test4(fwts_framework *fw) !((oldtime.TimeZone != 0) && (newtime.TimeZone == 0))) { fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetTimeTimezone", "Failed to set timezone with UEFI runtime service."); + fwts_advice(fw, + "Some system firmware may not support the timezone " + "value EFI_UNSPECIFIED_TIMEZONE(2047) and set the " + "value 0 directly instead of returning an error which " + "causes the failure."); return FWTS_ERROR; }