From patchwork Tue Jun 22 17:47:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1495821 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G8YlB0D0bz9s1l for ; Wed, 23 Jun 2021 03:47:49 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lvkUx-000163-Tg; Tue, 22 Jun 2021 17:47:43 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lvkUw-00015q-0d for fwts-devel@lists.ubuntu.com; Tue, 22 Jun 2021 17:47:42 +0000 Received: from d75-158-101-9.abhsia.telus.net ([75.158.101.9] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lvkUv-0005uH-CI; Tue, 22 Jun 2021 17:47:41 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: acpitables: add advices for table revision tests Date: Tue, 22 Jun 2021 11:47:37 -0600 Message-Id: <20210622174737.1198204-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- src/acpi/acpitables/acpitables.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c index 67224633..2ecaaa33 100644 --- a/src/acpi/acpitables/acpitables.c +++ b/src/acpi/acpitables/acpitables.c @@ -307,6 +307,12 @@ static int acpi_table_check_test2(fwts_framework *fw) if (!failed) fwts_passed(fw, "ACPI spec %4.4" PRIx32 " has matched table revisions.", version); + else + fwts_advice(fw, + "In \"ACPI Table Revision Overview\", ASWG suggests \"Conforming to a given ACPI " + "specification means that each and every ACPI-related table conforms to the version " + "number for that table that is listed in that version of the specification.\" " + "Please refer to https://uefi.org/node/4185 for details."); return FWTS_OK; }