diff mbox series

[2/3] sbbr: update recommended tables

Message ID 20210604051117.428840-2-alex.hung@canonical.com
State Accepted
Headers show
Series [1/3] sbbr: add checks for mandatory tables | expand

Commit Message

Alex Hung June 4, 2021, 5:11 a.m. UTC
This is based on APPENDIX E of Arm Server Base Boot Requirements (SBBR)
1.2

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/sbbr/acpitables/acpitables.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

Comments

ivanhu June 7, 2021, 8:37 a.m. UTC | #1
On 6/4/21 1:11 PM, Alex Hung wrote:
> This is based on APPENDIX E of Arm Server Base Boot Requirements (SBBR)
> 1.2
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/sbbr/acpitables/acpitables.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index 0919250b..3a378e03 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -213,20 +213,24 @@ static const char *mandatory_acpi_tables[] = {
>  
>  /* List of ACPI tables recommended by SBBR 4.2.2 */
>  static const char *recommended_acpi_tables[] = {
> -	"MCFG",
> +	/* I/O Topology */
>  	"IORT",
> +	/* Platform Error Interfaces */
>  	"BERT",
>  	"EINJ",
>  	"ERST",
>  	"HEST",
> -	"RASF",
> -	"SPMI",
> +	"SDEI",
> +	/* NUMA */
>  	"SLIT",
>  	"SRAT",
> -	"CSRT",
> -	"ECDT",
> -	"MPST",
> +	"HMAT",
> +	/* Platform Communications Channel (PCC) */
>  	"PCCT",
> +	/* Platform Debug Trigger */
> +	"PDTT",
> +	/* NVDIMM Firmware Interface */
> +	"NFIT",
>  	NULL
>  };
>  
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Colin King June 14, 2021, 5:32 p.m. UTC | #2
On 04/06/2021 06:11, Alex Hung wrote:
> This is based on APPENDIX E of Arm Server Base Boot Requirements (SBBR)
> 1.2
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/sbbr/acpitables/acpitables.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index 0919250b..3a378e03 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -213,20 +213,24 @@ static const char *mandatory_acpi_tables[] = {
>  
>  /* List of ACPI tables recommended by SBBR 4.2.2 */
>  static const char *recommended_acpi_tables[] = {
> -	"MCFG",
> +	/* I/O Topology */
>  	"IORT",
> +	/* Platform Error Interfaces */
>  	"BERT",
>  	"EINJ",
>  	"ERST",
>  	"HEST",
> -	"RASF",
> -	"SPMI",
> +	"SDEI",
> +	/* NUMA */
>  	"SLIT",
>  	"SRAT",
> -	"CSRT",
> -	"ECDT",
> -	"MPST",
> +	"HMAT",
> +	/* Platform Communications Channel (PCC) */
>  	"PCCT",
> +	/* Platform Debug Trigger */
> +	"PDTT",
> +	/* NVDIMM Firmware Interface */
> +	"NFIT",
>  	NULL
>  };
>  
> 

Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox series

Patch

diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
index 0919250b..3a378e03 100644
--- a/src/sbbr/acpitables/acpitables.c
+++ b/src/sbbr/acpitables/acpitables.c
@@ -213,20 +213,24 @@  static const char *mandatory_acpi_tables[] = {
 
 /* List of ACPI tables recommended by SBBR 4.2.2 */
 static const char *recommended_acpi_tables[] = {
-	"MCFG",
+	/* I/O Topology */
 	"IORT",
+	/* Platform Error Interfaces */
 	"BERT",
 	"EINJ",
 	"ERST",
 	"HEST",
-	"RASF",
-	"SPMI",
+	"SDEI",
+	/* NUMA */
 	"SLIT",
 	"SRAT",
-	"CSRT",
-	"ECDT",
-	"MPST",
+	"HMAT",
+	/* Platform Communications Channel (PCC) */
 	"PCCT",
+	/* Platform Debug Trigger */
+	"PDTT",
+	/* NVDIMM Firmware Interface */
+	"NFIT",
 	NULL
 };