diff mbox series

mtrr: remove ioctl header include, it is redundant

Message ID 20210408102136.560619-1-colin.king@canonical.com
State Accepted
Headers show
Series mtrr: remove ioctl header include, it is redundant | expand

Commit Message

Colin Ian King April 8, 2021, 10:21 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The ioctl mtrr interface was removed in commit 0a10760a877a
("read /proc/mtrr rather than use ioctl() interface") hence the
include of <sys/ioctl.h> is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/bios/mtrr/mtrr.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alex Hung April 8, 2021, 7:02 p.m. UTC | #1 
On 2021-04-08 4:21 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The ioctl mtrr interface was removed in commit 0a10760a877a
> ("read /proc/mtrr rather than use ioctl() interface") hence the
> include of <sys/ioctl.h> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/bios/mtrr/mtrr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/bios/mtrr/mtrr.c b/src/bios/mtrr/mtrr.c
> index 94905c24..1968edc5 100644
> --- a/src/bios/mtrr/mtrr.c
> +++ b/src/bios/mtrr/mtrr.c
> @@ -29,7 +29,6 @@
>  #include <stdbool.h>
>  #include <sys/types.h>
>  #include <sys/stat.h>
> -#include <sys/ioctl.h>
>  #include <fcntl.h>
>  #include <unistd.h>
>  #include <ctype.h>
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu April 12, 2021, 6:48 a.m. UTC | #2 
On 4/8/21 6:21 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The ioctl mtrr interface was removed in commit 0a10760a877a
> ("read /proc/mtrr rather than use ioctl() interface") hence the
> include of <sys/ioctl.h> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/bios/mtrr/mtrr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/bios/mtrr/mtrr.c b/src/bios/mtrr/mtrr.c
> index 94905c24..1968edc5 100644
> --- a/src/bios/mtrr/mtrr.c
> +++ b/src/bios/mtrr/mtrr.c
> @@ -29,7 +29,6 @@
>  #include <stdbool.h>
>  #include <sys/types.h>
>  #include <sys/stat.h>
> -#include <sys/ioctl.h>
>  #include <fcntl.h>
>  #include <unistd.h>
>  #include <ctype.h>
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/bios/mtrr/mtrr.c b/src/bios/mtrr/mtrr.c
index 94905c24..1968edc5 100644
--- a/src/bios/mtrr/mtrr.c
+++ b/src/bios/mtrr/mtrr.c
@@ -29,7 +29,6 @@ 
 #include <stdbool.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <sys/ioctl.h>
 #include <fcntl.h>
 #include <unistd.h>
 #include <ctype.h>