| Message ID | 20210330105148.1060390-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi: s3: ensure duration is initialized | expand |
On 2021-03-30 4:51 a.m., Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pedantic static analyzers complain that variable duration is not > initialized. Ensure it really is by setting it to zero. > > Addresses-Coverity: ("Uninitialized scalar variable"). > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/s3/s3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c > index 9cc94a17..fd47c861 100644 > --- a/src/acpi/s3/s3.c > +++ b/src/acpi/s3/s3.c > @@ -236,7 +236,7 @@ static int s3_do_suspend_resume(fwts_framework *fw, > { > fwts_hwinfo hwinfo1, hwinfo2; > int status; > - int duration; > + int duration = 0; > int differences; > int rc = FWTS_OK; > char *command = NULL; > Acked-by: Alex Hung <alex.hung@canonical.com>
On 3/30/21 6:51 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pedantic static analyzers complain that variable duration is not > initialized. Ensure it really is by setting it to zero. > > Addresses-Coverity: ("Uninitialized scalar variable"). > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/s3/s3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c > index 9cc94a17..fd47c861 100644 > --- a/src/acpi/s3/s3.c > +++ b/src/acpi/s3/s3.c > @@ -236,7 +236,7 @@ static int s3_do_suspend_resume(fwts_framework *fw, > { > fwts_hwinfo hwinfo1, hwinfo2; > int status; > - int duration; > + int duration = 0; > int differences; > int rc = FWTS_OK; > char *command = NULL; Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c index 9cc94a17..fd47c861 100644 --- a/src/acpi/s3/s3.c +++ b/src/acpi/s3/s3.c @@ -236,7 +236,7 @@ static int s3_do_suspend_resume(fwts_framework *fw, { fwts_hwinfo hwinfo1, hwinfo2; int status; - int duration; + int duration = 0; int differences; int rc = FWTS_OK; char *command = NULL;