| Message ID | 20210330104331.1059803-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi: madt: replace continue with empty statement ; | expand |
On 2021-03-30 4:43 a.m., Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Some static analyzers warn that the continue has no effect, clean > this up by replacing it with ; instead. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/madt/madt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c > index 295cd012..e164e5e1 100644 > --- a/src/acpi/madt/madt.c > +++ b/src/acpi/madt/madt.c > @@ -883,7 +883,8 @@ static int madt_local_sapic(fwts_framework *fw, > } > > for (tmp = 0, ii = 0; ii < 3; tmp |= lsapic->reserved[ii], ii++) > - continue; > + ; > + > if (tmp) > fwts_failed(fw, LOG_LEVEL_MEDIUM, > "MADTLSAPICReservedNonZero", > Acked-by: Alex Hung <alex.hung@canonical.com>
On 3/30/21 6:43 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Some static analyzers warn that the continue has no effect, clean > this up by replacing it with ; instead. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/madt/madt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c > index 295cd012..e164e5e1 100644 > --- a/src/acpi/madt/madt.c > +++ b/src/acpi/madt/madt.c > @@ -883,7 +883,8 @@ static int madt_local_sapic(fwts_framework *fw, > } > > for (tmp = 0, ii = 0; ii < 3; tmp |= lsapic->reserved[ii], ii++) > - continue; > + ; > + > if (tmp) > fwts_failed(fw, LOG_LEVEL_MEDIUM, > "MADTLSAPICReservedNonZero", Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c index 295cd012..e164e5e1 100644 --- a/src/acpi/madt/madt.c +++ b/src/acpi/madt/madt.c @@ -883,7 +883,8 @@ static int madt_local_sapic(fwts_framework *fw, } for (tmp = 0, ii = 0; ii < 3; tmp |= lsapic->reserved[ii], ii++) - continue; + ; + if (tmp) fwts_failed(fw, LOG_LEVEL_MEDIUM, "MADTLSAPICReservedNonZero",