diff mbox series

[1/2] acpi/pptt: add a warning for type 2 depreciation

Message ID 20201009004309.213751-1-alex.hung@canonical.com
State Accepted
Headers show
Series [1/2] acpi/pptt: add a warning for type 2 depreciation | expand

Commit Message

Alex Hung Oct. 9, 2020, 12:43 a.m. UTC
Type 2 is depreciated since ACPI 6.3 errata A (mantis 2072).

See details in https://bugzilla.tianocore.org/show_bug.cgi?id=2492

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/pptt/pptt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Colin Ian King Oct. 9, 2020, 8:33 a.m. UTC | #1
On 09/10/2020 01:43, Alex Hung wrote:
> Type 2 is depreciated since ACPI 6.3 errata A (mantis 2072).
> 
> See details in https://bugzilla.tianocore.org/show_bug.cgi?id=2492
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/pptt/pptt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/acpi/pptt/pptt.c b/src/acpi/pptt/pptt.c
> index 4fdd005b..bf361dc0 100644
> --- a/src/acpi/pptt/pptt.c
> +++ b/src/acpi/pptt/pptt.c
> @@ -145,6 +145,7 @@ static int pptt_test1(fwts_framework *fw)
>  			pptt_cache_test(fw, (fwts_acpi_table_pptt_cache *) entry, &passed);
>  			type_length = sizeof(fwts_acpi_table_pptt_cache);
>  		} else if (entry->type == FWTS_ACPI_PPTT_ID) {
> +			fwts_log_warning(fw, "PPTT type 2 is depreciated since ACPI 6.3 Errata A.");
>  			pptt_id_test(fw, (fwts_acpi_table_pptt_id *) entry, &passed);
>  			type_length = sizeof(fwts_acpi_table_pptt_id);
>  		} else {
> 
Thanks Alex,

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu Oct. 12, 2020, 2:48 a.m. UTC | #2
On 10/9/20 8:43 AM, Alex Hung wrote:
> Type 2 is depreciated since ACPI 6.3 errata A (mantis 2072).
> 
> See details in https://bugzilla.tianocore.org/show_bug.cgi?id=2492
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/pptt/pptt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/acpi/pptt/pptt.c b/src/acpi/pptt/pptt.c
> index 4fdd005b..bf361dc0 100644
> --- a/src/acpi/pptt/pptt.c
> +++ b/src/acpi/pptt/pptt.c
> @@ -145,6 +145,7 @@ static int pptt_test1(fwts_framework *fw)
>  			pptt_cache_test(fw, (fwts_acpi_table_pptt_cache *) entry, &passed);
>  			type_length = sizeof(fwts_acpi_table_pptt_cache);
>  		} else if (entry->type == FWTS_ACPI_PPTT_ID) {
> +			fwts_log_warning(fw, "PPTT type 2 is depreciated since ACPI 6.3 Errata A.");
>  			pptt_id_test(fw, (fwts_acpi_table_pptt_id *) entry, &passed);
>  			type_length = sizeof(fwts_acpi_table_pptt_id);
>  		} else {
> 


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/acpi/pptt/pptt.c b/src/acpi/pptt/pptt.c
index 4fdd005b..bf361dc0 100644
--- a/src/acpi/pptt/pptt.c
+++ b/src/acpi/pptt/pptt.c
@@ -145,6 +145,7 @@  static int pptt_test1(fwts_framework *fw)
 			pptt_cache_test(fw, (fwts_acpi_table_pptt_cache *) entry, &passed);
 			type_length = sizeof(fwts_acpi_table_pptt_cache);
 		} else if (entry->type == FWTS_ACPI_PPTT_ID) {
+			fwts_log_warning(fw, "PPTT type 2 is depreciated since ACPI 6.3 Errata A.");
 			pptt_id_test(fw, (fwts_acpi_table_pptt_id *) entry, &passed);
 			type_length = sizeof(fwts_acpi_table_pptt_id);
 		} else {