diff mbox

uefi: uefirtmisc: make gEfiCapsuleHeaderGuid static

Message ID 20170130164310.28088-1-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Jan. 30, 2017, 4:43 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

gEfiCapsuleHeaderGuid is currently in global scope and doesn't
need to be. Make it static.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/uefi/uefirtmisc/uefirtmisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ivan Hu Feb. 2, 2017, 7:02 a.m. UTC | #1 
On 2017年01月31日 00:43, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> gEfiCapsuleHeaderGuid is currently in global scope and doesn't
> need to be. Make it static.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/uefi/uefirtmisc/uefirtmisc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefirtmisc/uefirtmisc.c b/src/uefi/uefirtmisc/uefirtmisc.c
> index 98ae472..70068c9 100644
> --- a/src/uefi/uefirtmisc/uefirtmisc.c
> +++ b/src/uefi/uefirtmisc/uefirtmisc.c
> @@ -41,7 +41,7 @@
>  }
>
>  static int fd;
> -EFI_GUID gEfiCapsuleHeaderGuid = EFI_CAPSULE_GUID;
> +static EFI_GUID gEfiCapsuleHeaderGuid = EFI_CAPSULE_GUID;
>
>  static int uefirtmisc_init(fwts_framework *fw)
>  {
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Alex Hung Feb. 3, 2017, 3:23 a.m. UTC | #2 
On 2017-01-31 12:43 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> gEfiCapsuleHeaderGuid is currently in global scope and doesn't
> need to be. Make it static.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/uefi/uefirtmisc/uefirtmisc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefirtmisc/uefirtmisc.c b/src/uefi/uefirtmisc/uefirtmisc.c
> index 98ae472..70068c9 100644
> --- a/src/uefi/uefirtmisc/uefirtmisc.c
> +++ b/src/uefi/uefirtmisc/uefirtmisc.c
> @@ -41,7 +41,7 @@
>  }
>
>  static int fd;
> -EFI_GUID gEfiCapsuleHeaderGuid = EFI_CAPSULE_GUID;
> +static EFI_GUID gEfiCapsuleHeaderGuid = EFI_CAPSULE_GUID;
>
>  static int uefirtmisc_init(fwts_framework *fw)
>  {
>


Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox

Patch

diff --git a/src/uefi/uefirtmisc/uefirtmisc.c b/src/uefi/uefirtmisc/uefirtmisc.c
index 98ae472..70068c9 100644
--- a/src/uefi/uefirtmisc/uefirtmisc.c
+++ b/src/uefi/uefirtmisc/uefirtmisc.c
@@ -41,7 +41,7 @@ 
 }
 
 static int fd;
-EFI_GUID gEfiCapsuleHeaderGuid = EFI_CAPSULE_GUID;
+static EFI_GUID gEfiCapsuleHeaderGuid = EFI_CAPSULE_GUID;
 
 static int uefirtmisc_init(fwts_framework *fw)
 {