From patchwork Thu Oct 29 20:39:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Stone X-Patchwork-Id: 538023 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 5E48614130A; Fri, 30 Oct 2015 07:40:00 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro_org.20150623.gappssmtp.com header.i=@linaro_org.20150623.gappssmtp.com header.b=ikkumJwI; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1ZrtzK-0004Lg-F6; Thu, 29 Oct 2015 20:39:58 +0000 Received: from mail-oi0-f45.google.com ([209.85.218.45]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1ZrtzC-0004LM-Lo for fwts-devel@lists.ubuntu.com; Thu, 29 Oct 2015 20:39:50 +0000 Received: by oifu63 with SMTP id u63so48252437oif.2 for ; Thu, 29 Oct 2015 13:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=QobYWiyh4KYhJcmBgtTNa4zkzq0888EHr0CMibwEZiY=; b=ikkumJwI7dLeQU90mnEw/6A4djg6AHn+n1keEKeyJF7odc4aMRl2nnkU7cxV5/lmdV CrZ1xlwFuTzaZxPwWbU4zL4PuyKag7dk7NXMHgWKQ4BYKuznBLw/I1+ILrCZdz9I/Fjh FYjDaFhos3IrklkaZhBs3vk07AUyDLtwr4Heb8f9TOQzlM7gz+3jTxd8RCrKJQkiP9Ly Lp37JXE2Pm/ZTjAyB7h/Axs4gTmATHm9bZ385d1MNLGVbigAYt2UJx/YHHWWtW17SHFO du2xsOQChx5T5vuszNPi8oNkvLIm1wd0IgBehmiaPq5gkh18krbKBRfIVOI/K9lpvWIj YH2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QobYWiyh4KYhJcmBgtTNa4zkzq0888EHr0CMibwEZiY=; b=O4iALa4sRCYUHpxU/wGZEmCHGZygG+oESu+lWgdAyy7mfyh0yEoUZBNimQV5mDYxHK s3RFZl0n/edKFXtgepMPnoT5K9ujbO/ipWs8RZVUIejH2AfAwIkf0YdXgVuORnjB281L 3q19fYyYdDFTZcM6zglAaQGjcrhVJSOoD/fT7/oUBJtkgW5QPbDDjdvgI2uNLWLUSDnw WkwN/hF1s21u/ZMVh93sJHAgS8RLfiq0x6VD/2s16t1V1XsxUrPIa+OT1ug4mFcsk34y ntaO9LX3mcyHn8vnwaTxVXCpbKSlRN0yUKjSca2zqpiL0sWm/dstturYqHlHYcyeUorP C3Uw== X-Gm-Message-State: ALoCoQmYqqYe+xMhHmrhuCJnNKN1XelXpdhKiCqIyTIs9TUDp7Sy+084+FTQYmgZRvHqJCDgbhti X-Received: by 10.202.179.198 with SMTP id c189mr2893743oif.67.1446151190050; Thu, 29 Oct 2015 13:39:50 -0700 (PDT) Received: from fidelio.ahs3.com (c-50-134-239-249.hsd1.co.comcast.net. [50.134.239.249]) by smtp.googlemail.com with ESMTPSA id ik9sm1294392obc.1.2015.10.29.13.39.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Oct 2015 13:39:48 -0700 (PDT) From: Al Stone To: fwts-devel@lists.ubuntu.com Subject: [PATCH] MADT subtables: Local SAPIC structure has 3 reserved bytes, not 1 Date: Thu, 29 Oct 2015 14:39:36 -0600 Message-Id: <1446151176-22234-1-git-send-email-al.stone@linaro.org> X-Mailer: git-send-email 2.4.3 Cc: patches@linaro.org, linaro-acpi@lists.linaro.org X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com According to section 5.2.12.10 of the ACPI 6.0 spec, the reserved field starts at byte offset 5 and is 3 bytes long. However, the subtable data structure being used makes it only 1 byte long. This is incorrect, so fix it. Signed-off-by: Al Stone Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/include/fwts_acpi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h index 5cc4cb4..cf8f4b8 100644 --- a/src/lib/include/fwts_acpi.h +++ b/src/lib/include/fwts_acpi.h @@ -473,7 +473,7 @@ typedef struct { uint8_t acpi_processor_id; uint8_t local_sapic_id; uint8_t local_sapic_eid; - uint8_t reserved; + uint8_t reserved[3]; uint32_t flags; uint32_t uid_value; char uid_string[0];