From patchwork Tue Jun 17 19:04:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 360772 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id E856914007B; Wed, 18 Jun 2014 05:05:05 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1Wwygp-0003mk-Gi; Tue, 17 Jun 2014 19:05:03 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1Wwygk-0003iN-Dv for fwts-devel@lists.ubuntu.com; Tue, 17 Jun 2014 19:04:58 +0000 Received: from 216-129-87-74.dedicated.allstream.net ([216.129.87.74] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Wwygk-0002p1-0W; Tue, 17 Jun 2014 19:04:58 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] [v2] cpu: microcode: remove failures when kernel does not have newer version (LP: #1322534) Date: Tue, 17 Jun 2014 12:04:53 -0700 Message-Id: <1403031893-29436-1-git-send-email-alex.hung@canonical.com> X-Mailer: git-send-email 1.9.1 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com New systems usually have new microcode than kernel does, and therefore reporting failures is not correct. This patch changes it to report skipped when kernel does not have microcode updates. Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- src/cpu/microcode/microcode.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c index 016b938..4434275 100644 --- a/src/cpu/microcode/microcode.c +++ b/src/cpu/microcode/microcode.c @@ -230,13 +230,10 @@ static int microcode_test1(fwts_framework *fw) } /* - * We found the old revision but not a - * new revsion, failed + * Kernel does not have newer version than BIOS */ if (info->new_revision == UNKNOWN) { - failed++; - fwts_failed(fw, LOG_LEVEL_MEDIUM, "MicrocodeNotUpdated", - "The kernel did not report that CPU %d has had a microcode update. " + fwts_log_info(fw, "The kernel did not report that CPU %d has had a microcode update. " "The current firmware is revision 0x%x and probably has not been updated.", cpu, info->old_revision); continue;