From patchwork Fri Sep 7 16:58:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 182427 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 9FB422C0095 for ; Sat, 8 Sep 2012 02:58:22 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TA1rZ-0006lx-6l; Fri, 07 Sep 2012 16:57:01 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TA1rX-0006lq-8j for fwts-devel@lists.ubuntu.com; Fri, 07 Sep 2012 16:56:59 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TA1sp-0000Mg-AW for fwts-devel@lists.ubuntu.com; Fri, 07 Sep 2012 16:58:19 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_framework: fix unnecessary escaping Date: Fri, 7 Sep 2012 17:58:18 +0100 Message-Id: <1347037098-8326-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King The log-format help information contains unneccessary and incorrect escaping, found using the smatch tool. These need fixing. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/lib/src/fwts_framework.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c index 30645b6..927ee54 100644 --- a/src/lib/src/fwts_framework.c +++ b/src/lib/src/fwts_framework.c @@ -52,7 +52,7 @@ static fwts_option fwts_framework_options[] = { { "results-no-separators", "", 0, "No horizontal separators in results log." }, { "log-filter", "", 1, "Define filters to dump out specific log fields: --log-filter=RES,SUM - dump out results and summary, --log-filter=ALL,~INF - dump out all fields except info fields." }, { "log-fields", "", 0, "Show available log filtering fields." }, - { "log-format", "", 1, "Define output log format: e.g. --log-format=\"\%date \%time [\%field] (\%owner): \". Fields are: \%time - time, \%field - filter field, \%owner - name of test, \%level - failure error level, \%line - log line number." }, + { "log-format", "", 1, "Define output log format: e.g. --log-format=\"%date %time [%field] (%owner): \". Fields are: %time - time, %field - filter field, %owner - name of test, %level - failure error level, %line - log line number." }, { "show-progress", "p", 0, "Output test progress report to stderr." }, { "show-tests", "s", 0, "Show available tests." }, { "klog", "k:", 1, "Specify kernel log file rather than reading it from the kernel, e.g. --klog=dmesg.log" },