| Message ID | 1334067944-1702-1-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On 04/10/2012 10:25 PM, Colin King wrote: > From: Colin Ian King<colin.king@canonical.com> > > Signed-off-by: Colin Ian King<colin.king@canonical.com> > --- > src/acpi/acpitables/acpitables.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c > index 2ff29b2..432407c 100644 > --- a/src/acpi/acpitables/acpitables.c > +++ b/src/acpi/acpitables/acpitables.c > @@ -292,7 +292,7 @@ static void acpi_table_check_madt(fwts_framework *fw, fwts_acpi_table_info *tabl > { > fwts_acpi_table_madt *madt = (fwts_acpi_table_madt*)table->data; > const void *data = table->data; > - int length = table->length; > + size_t length = table->length; > int i = 0; > > if (madt->flags& 0xfffffffe) > @@ -302,8 +302,8 @@ static void acpi_table_check_madt(fwts_framework *fw, fwts_acpi_table_info *tabl > data += sizeof(fwts_acpi_table_madt); > length -= sizeof(fwts_acpi_table_madt); > > - while (length> (int)sizeof(fwts_acpi_madt_sub_table_header)) { > - int skip = 0; > + while (length> sizeof(fwts_acpi_madt_sub_table_header)) { > + size_t skip = 0; > i++; > fwts_acpi_madt_sub_table_header *hdr = (fwts_acpi_madt_sub_table_header*)data; > Acked-by: Alex Hung <alex.hung@canonical.com>
On Wed, Apr 11, 2012 at 9:51 AM, Alex Hung <alex.hung@canonical.com> wrote: > On 04/10/2012 10:25 PM, Colin King wrote: >> >> From: Colin Ian King<colin.king@canonical.com> >> >> Signed-off-by: Colin Ian King<colin.king@canonical.com> >> --- >> src/acpi/acpitables/acpitables.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/src/acpi/acpitables/acpitables.c >> b/src/acpi/acpitables/acpitables.c >> index 2ff29b2..432407c 100644 >> --- a/src/acpi/acpitables/acpitables.c >> +++ b/src/acpi/acpitables/acpitables.c >> @@ -292,7 +292,7 @@ static void acpi_table_check_madt(fwts_framework *fw, >> fwts_acpi_table_info *tabl >> { >> fwts_acpi_table_madt *madt = (fwts_acpi_table_madt*)table->data; >> const void *data = table->data; >> - int length = table->length; >> + size_t length = table->length; >> int i = 0; >> >> if (madt->flags& 0xfffffffe) >> >> @@ -302,8 +302,8 @@ static void acpi_table_check_madt(fwts_framework *fw, >> fwts_acpi_table_info *tabl >> data += sizeof(fwts_acpi_table_madt); >> length -= sizeof(fwts_acpi_table_madt); >> >> - while (length> (int)sizeof(fwts_acpi_madt_sub_table_header)) { >> - int skip = 0; >> + while (length> sizeof(fwts_acpi_madt_sub_table_header)) { >> + size_t skip = 0; >> i++; >> fwts_acpi_madt_sub_table_header *hdr = >> (fwts_acpi_madt_sub_table_header*)data; >> > Acked-by: Alex Hung <alex.hung@canonical.com> > > Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c index 2ff29b2..432407c 100644 --- a/src/acpi/acpitables/acpitables.c +++ b/src/acpi/acpitables/acpitables.c @@ -292,7 +292,7 @@ static void acpi_table_check_madt(fwts_framework *fw, fwts_acpi_table_info *tabl { fwts_acpi_table_madt *madt = (fwts_acpi_table_madt*)table->data; const void *data = table->data; - int length = table->length; + size_t length = table->length; int i = 0; if (madt->flags & 0xfffffffe) @@ -302,8 +302,8 @@ static void acpi_table_check_madt(fwts_framework *fw, fwts_acpi_table_info *tabl data += sizeof(fwts_acpi_table_madt); length -= sizeof(fwts_acpi_table_madt); - while (length > (int)sizeof(fwts_acpi_madt_sub_table_header)) { - int skip = 0; + while (length > sizeof(fwts_acpi_madt_sub_table_header)) { + size_t skip = 0; i++; fwts_acpi_madt_sub_table_header *hdr = (fwts_acpi_madt_sub_table_header*)data;