| Message ID | 5f540de10445ae419ce3e49b860603cd@veghelyiattila.hu |
|---|---|
| State | New |
| Headers | show |
| Series | W25Q256JV_Q is checked | expand |
Hello Attila, Thank you so much for reporting all the testing details and logs, this is very useful! Is this your patch that you sent some time ago https://review.coreboot.org/c/flashrom/+/86085 ? I was wondering why you disappear after sending the patch :) There are two things in your message: 1) You have successfully tested W25Q256JV_Q which previously has untested status. I updated the test status of this chip and added a Tested-by tag with your name, are you alright with that? Hopefully yes, if you could +1 the patch https://review.coreboot.org/c/flashrom/+/87459 it would be great! I copied your name and email from your patch that you sent earlier, see below: 2) About your earlier patch https://review.coreboot.org/c/flashrom/+/86085 what do you think can it be useful for other people (flashrom users) too? I understand that you needed a longer delay in your setup, this could be a programmer param to customise the delay - depending on how unique or common this setup is. > [ I tried to ask merge request via Jenkins, but it was too complicated > for modify one char in the source ;-) ] You created the patch successfully! :) But then, we always have code reviews and sometimes a patch can be modified in the process of review. On Fri, Apr 25, 2025 at 8:32 PM <works@veghelyiattila.hu> wrote: > > hi, > > I checked the PROBE - READ - ERASE - WRITE operations of the W25Q256JV_Q > flash with J-Link and CH341 spi writers. > the flashrom version was the newest development release at 2025-04-14 > (#4d4688ccf132c580107b013d2d929a0816aa89c1) > I made a little modification in the 'jlink_spi.c' source, because I use > the power supply from the J-Link device pin 19. > this power is 5V, I put a 3.3V LDO (HT7333) after it, and this LDO (and > decoupling capacitors) need more time to fix output voltage. > I attached the patch file. > [ I tried to ask merge request via Jenkins, but it was too complicated > for modify one char in the source ;-) ] > > my flash type was Winbond 25Q256JVEQ, which recognized by flashrom to > W25Q256JV_Q or W25Q256FV, both type probed, read, wrote, erased, both > modality worked fine. > > regards, > > Attila_______________________________________________ > flashrom mailing list -- flashrom@flashrom.org > To unsubscribe send an email to flashrom-leave@flashrom.org
diff --git a/jlink_spi.c b/jlink_spi.c index 6c5a5249..d970cdfb 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -465,7 +465,7 @@ static int jlink_spi_init(const struct programmer_cfg *cfg) } /* Wait some time until the target is powered up. */ - internal_sleep(10000); + internal_sleep(100000); } struct jaylink_hardware_status hwstat;