diff mbox

[10/17] nfsref: Avoid buffer overrun in nfsref command

Message ID 20140527153747.1177.30084.stgit@seurat.1015granger.net
State Accepted
Headers show

Commit Message

Chuck Lever May 27, 2014, 3:37 p.m. UTC 
Fixes: 04a9ffdfdb3ae73724b4293eade7d7c9dc342d8f
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 src/nfsref/add.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/src/nfsref/add.c b/src/nfsref/add.c
index 848d1d4f0f95..af9f39bcf319 100644
--- a/src/nfsref/add.c
+++ b/src/nfsref/add.c
@@ -313,7 +313,8 @@  nfsref_add_nfs_fsl_defaults(const char *server, const char *rootpath,
 {
 	FedFsStatus retval;
 
-	/* XXX: check the server hostname length */
+	if (strlen(server) >= sizeof(new->fn_fslhost))
+		return FEDFS_ERR_NAMETOOLONG;
 	strcpy(new->fn_fslhost, server);
 	new->fn_fslport = 0;