diff mbox

[04/17] libnsdb: Fix possible buffer overrun in nsdb_parse_nfs_uri_fsl()

Message ID 20140527153658.1177.30827.stgit@seurat.1015granger.net
State Accepted
Headers show

Commit Message

Chuck Lever May 27, 2014, 3:36 p.m. UTC 
Ensure the contents placed in string[] will always be
'\0'-terminated.

Fixes: 04a9ffdfdb3ae73724b4293eade7d7c9dc342d8f
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 src/libnsdb/fileserver.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c
index 96fad2c5e1ee..ddc21a6a5fd5 100644
--- a/src/libnsdb/fileserver.c
+++ b/src/libnsdb/fileserver.c
@@ -761,7 +761,7 @@  nsdb_parse_nfs_uri_fsl(const char *attr, UriUriA *uri,
 		size_t portlen;
 
 		portlen = uri->portText.afterLast - uri->portText.first;
-		if (portlen > sizeof(string)) {
+		if (portlen > sizeof(string) - 1) {
 			xlog(L_ERROR, "%s: NFS URI has invalid port",
 				__func__, attr);
 			goto out;