| Message ID | fb0bb969cd0e5872ab5eac70e070242c0d8a5b81.1619700202.git.geert+renesas@glider.be |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: PCI: rcar-pci-host: Document missing R-Car H1 support | expand |
| Context | Check | Description |
|---|---|---|
| robh/dtbs-check | success | |
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 24 lines checked |
| robh/dt-meta-schema | success |
On Thu, 29 Apr 2021 14:44:09 +0200, Geert Uytterhoeven wrote: > scripts/checkpatch.pl -f drivers/pci/controller/pcie-rcar-host.c: > > WARNING: DT compatible string "renesas,pcie-r8a7779" appears un-documented -- check ./Documentation/devicetree/bindings/ > #853: FILE: drivers/pci/controller/pcie-rcar-host.c:853: > + { .compatible = "renesas,pcie-r8a7779", > > Re-add the compatible value for R-Car H1, which was lost during the > json-schema conversion. Make the "resets" property optional on R-Car > H1, as it is not present yet on R-Car Gen1 SoCs. > > Fixes: 0d69ce3c2c63d4db ("dt-bindings: PCI: rcar-pci-host: Convert bindings to json-schema") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > This was never enabled in the upstream r8a7779.dtsi, but the Linux > driver does support it. > --- > .../devicetree/bindings/pci/rcar-pci-host.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml index 4a2bcc0158e2d49a..8fdfbc763d704532 100644 --- a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml +++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml @@ -17,6 +17,7 @@ allOf: properties: compatible: oneOf: + - const: renesas,pcie-r8a7779 # R-Car H1 - items: - enum: - renesas,pcie-r8a7742 # RZ/G1H @@ -74,7 +75,16 @@ required: - clocks - clock-names - power-domains - - resets + +if: + not: + properties: + compatible: + contains: + const: renesas,pcie-r8a7779 +then: + required: + - resets unevaluatedProperties: false
scripts/checkpatch.pl -f drivers/pci/controller/pcie-rcar-host.c: WARNING: DT compatible string "renesas,pcie-r8a7779" appears un-documented -- check ./Documentation/devicetree/bindings/ #853: FILE: drivers/pci/controller/pcie-rcar-host.c:853: + { .compatible = "renesas,pcie-r8a7779", Re-add the compatible value for R-Car H1, which was lost during the json-schema conversion. Make the "resets" property optional on R-Car H1, as it is not present yet on R-Car Gen1 SoCs. Fixes: 0d69ce3c2c63d4db ("dt-bindings: PCI: rcar-pci-host: Convert bindings to json-schema") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- This was never enabled in the upstream r8a7779.dtsi, but the Linux driver does support it. --- .../devicetree/bindings/pci/rcar-pci-host.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)