Message ID | f87ca786bca8abce6261dbd79a34218550355684.1438166099.git.viresh.kumar@linaro.org |
---|---|
State | Accepted, archived |
Commit | ba4539ffc19b090841cd32ffe2c57d937e311857 |
Headers | show |
On Wed, Jul 29, 2015 at 5:52 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > With a 32 bit value, the maximum frequency that the bindings can > support is ~ 4 GHz. And that might fall short of what newer systems may > have. 4GHz should be fast enough for anyone... > Allow opp-hz to be a 64 bit big-endian value. > > Cc: Rob Herring <rob.herring@linaro.org> Acked-by: Rob Herring <robh@kernel.org> > Cc: devicetree@vger.kernel.org > Suggested-by: Stephen Boyd <sboyd@codeaurora.org> > Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Documentation/devicetree/bindings/power/opp.txt | 40 ++++++++++++------------- > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt > index 0d5e7c978121..0cb44dc21f97 100644 > --- a/Documentation/devicetree/bindings/power/opp.txt > +++ b/Documentation/devicetree/bindings/power/opp.txt > @@ -88,7 +88,7 @@ This defines voltage-current-frequency combinations along with other related > properties. > > Required properties: > -- opp-hz: Frequency in Hz > +- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. > > Optional properties: > - opp-microvolt: voltage in micro Volts. > @@ -158,20 +158,20 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > opp-shared; > > opp00 { > - opp-hz = <1000000000>; > + opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > opp-suspend; > }; > opp01 { > - opp-hz = <1100000000>; > + opp-hz = /bits/ 64 <1100000000>; > opp-microvolt = <980000 1000000 1010000>; > opp-microamp = <80000>; > clock-latency-ns = <310000>; > }; > opp02 { > - opp-hz = <1200000000>; > + opp-hz = /bits/ 64 <1200000000>; > opp-microvolt = <1025000>; > clock-latency-ns = <290000>; > turbo-mode; > @@ -237,20 +237,20 @@ independently. > */ > > opp00 { > - opp-hz = <1000000000>; > + opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > opp-suspend; > }; > opp01 { > - opp-hz = <1100000000>; > + opp-hz = /bits/ 64 <1100000000>; > opp-microvolt = <980000 1000000 1010000>; > opp-microamp = <80000>; > clock-latency-ns = <310000>; > }; > opp02 { > - opp-hz = <1200000000>; > + opp-hz = /bits/ 64 <1200000000>; > opp-microvolt = <1025000>; > opp-microamp = <90000; > lock-latency-ns = <290000>; > @@ -313,20 +313,20 @@ DVFS state together. > opp-shared; > > opp00 { > - opp-hz = <1000000000>; > + opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > opp-suspend; > }; > opp01 { > - opp-hz = <1100000000>; > + opp-hz = /bits/ 64 <1100000000>; > opp-microvolt = <980000 1000000 1010000>; > opp-microamp = <80000>; > clock-latency-ns = <310000>; > }; > opp02 { > - opp-hz = <1200000000>; > + opp-hz = /bits/ 64 <1200000000>; > opp-microvolt = <1025000>; > opp-microamp = <90000>; > clock-latency-ns = <290000>; > @@ -339,20 +339,20 @@ DVFS state together. > opp-shared; > > opp10 { > - opp-hz = <1300000000>; > + opp-hz = /bits/ 64 <1300000000>; > opp-microvolt = <1045000 1050000 1055000>; > opp-microamp = <95000>; > clock-latency-ns = <400000>; > opp-suspend; > }; > opp11 { > - opp-hz = <1400000000>; > + opp-hz = /bits/ 64 <1400000000>; > opp-microvolt = <1075000>; > opp-microamp = <100000>; > clock-latency-ns = <400000>; > }; > opp12 { > - opp-hz = <1500000000>; > + opp-hz = /bits/ 64 <1500000000>; > opp-microvolt = <1010000 1100000 1110000>; > opp-microamp = <95000>; > clock-latency-ns = <400000>; > @@ -379,7 +379,7 @@ Example 4: Handling multiple regulators > opp-shared; > > opp00 { > - opp-hz = <1000000000>; > + opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000>, /* Supply 0 */ > <960000>, /* Supply 1 */ > <960000>; /* Supply 2 */ > @@ -392,7 +392,7 @@ Example 4: Handling multiple regulators > /* OR */ > > opp00 { > - opp-hz = <1000000000>; > + opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000 975000 985000>, /* Supply 0 */ > <960000 965000 975000>, /* Supply 1 */ > <960000 965000 975000>; /* Supply 2 */ > @@ -405,7 +405,7 @@ Example 4: Handling multiple regulators > /* OR */ > > opp00 { > - opp-hz = <1000000000>; > + opp-hz = /bits/ 64 <1000000000>; > opp-microvolt = <970000 975000 985000>, /* Supply 0 */ > <960000 965000 975000>, /* Supply 1 */ > <960000 965000 975000>; /* Supply 2 */ > @@ -437,12 +437,12 @@ Example 5: Multiple OPP tables > opp-shared; > > opp00 { > - opp-hz = <600000000>; > + opp-hz = /bits/ 64 <600000000>; > ... > }; > > opp01 { > - opp-hz = <800000000>; > + opp-hz = /bits/ 64 <800000000>; > ... > }; > }; > @@ -453,12 +453,12 @@ Example 5: Multiple OPP tables > opp-shared; > > opp10 { > - opp-hz = <1000000000>; > + opp-hz = /bits/ 64 <1000000000>; > ... > }; > > opp11 { > - opp-hz = <1100000000>; > + opp-hz = /bits/ 64 <1100000000>; > ... > }; > }; > -- > 2.4.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt index 0d5e7c978121..0cb44dc21f97 100644 --- a/Documentation/devicetree/bindings/power/opp.txt +++ b/Documentation/devicetree/bindings/power/opp.txt @@ -88,7 +88,7 @@ This defines voltage-current-frequency combinations along with other related properties. Required properties: -- opp-hz: Frequency in Hz +- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. Optional properties: - opp-microvolt: voltage in micro Volts. @@ -158,20 +158,20 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. opp-shared; opp00 { - opp-hz = <1000000000>; + opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; opp-suspend; }; opp01 { - opp-hz = <1100000000>; + opp-hz = /bits/ 64 <1100000000>; opp-microvolt = <980000 1000000 1010000>; opp-microamp = <80000>; clock-latency-ns = <310000>; }; opp02 { - opp-hz = <1200000000>; + opp-hz = /bits/ 64 <1200000000>; opp-microvolt = <1025000>; clock-latency-ns = <290000>; turbo-mode; @@ -237,20 +237,20 @@ independently. */ opp00 { - opp-hz = <1000000000>; + opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; opp-suspend; }; opp01 { - opp-hz = <1100000000>; + opp-hz = /bits/ 64 <1100000000>; opp-microvolt = <980000 1000000 1010000>; opp-microamp = <80000>; clock-latency-ns = <310000>; }; opp02 { - opp-hz = <1200000000>; + opp-hz = /bits/ 64 <1200000000>; opp-microvolt = <1025000>; opp-microamp = <90000; lock-latency-ns = <290000>; @@ -313,20 +313,20 @@ DVFS state together. opp-shared; opp00 { - opp-hz = <1000000000>; + opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; opp-suspend; }; opp01 { - opp-hz = <1100000000>; + opp-hz = /bits/ 64 <1100000000>; opp-microvolt = <980000 1000000 1010000>; opp-microamp = <80000>; clock-latency-ns = <310000>; }; opp02 { - opp-hz = <1200000000>; + opp-hz = /bits/ 64 <1200000000>; opp-microvolt = <1025000>; opp-microamp = <90000>; clock-latency-ns = <290000>; @@ -339,20 +339,20 @@ DVFS state together. opp-shared; opp10 { - opp-hz = <1300000000>; + opp-hz = /bits/ 64 <1300000000>; opp-microvolt = <1045000 1050000 1055000>; opp-microamp = <95000>; clock-latency-ns = <400000>; opp-suspend; }; opp11 { - opp-hz = <1400000000>; + opp-hz = /bits/ 64 <1400000000>; opp-microvolt = <1075000>; opp-microamp = <100000>; clock-latency-ns = <400000>; }; opp12 { - opp-hz = <1500000000>; + opp-hz = /bits/ 64 <1500000000>; opp-microvolt = <1010000 1100000 1110000>; opp-microamp = <95000>; clock-latency-ns = <400000>; @@ -379,7 +379,7 @@ Example 4: Handling multiple regulators opp-shared; opp00 { - opp-hz = <1000000000>; + opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000>, /* Supply 0 */ <960000>, /* Supply 1 */ <960000>; /* Supply 2 */ @@ -392,7 +392,7 @@ Example 4: Handling multiple regulators /* OR */ opp00 { - opp-hz = <1000000000>; + opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>, /* Supply 0 */ <960000 965000 975000>, /* Supply 1 */ <960000 965000 975000>; /* Supply 2 */ @@ -405,7 +405,7 @@ Example 4: Handling multiple regulators /* OR */ opp00 { - opp-hz = <1000000000>; + opp-hz = /bits/ 64 <1000000000>; opp-microvolt = <970000 975000 985000>, /* Supply 0 */ <960000 965000 975000>, /* Supply 1 */ <960000 965000 975000>; /* Supply 2 */ @@ -437,12 +437,12 @@ Example 5: Multiple OPP tables opp-shared; opp00 { - opp-hz = <600000000>; + opp-hz = /bits/ 64 <600000000>; ... }; opp01 { - opp-hz = <800000000>; + opp-hz = /bits/ 64 <800000000>; ... }; }; @@ -453,12 +453,12 @@ Example 5: Multiple OPP tables opp-shared; opp10 { - opp-hz = <1000000000>; + opp-hz = /bits/ 64 <1000000000>; ... }; opp11 { - opp-hz = <1100000000>; + opp-hz = /bits/ 64 <1100000000>; ... }; };
With a 32 bit value, the maximum frequency that the bindings can support is ~ 4 GHz. And that might fall short of what newer systems may have. Allow opp-hz to be a 64 bit big-endian value. Cc: Rob Herring <rob.herring@linaro.org> Cc: devicetree@vger.kernel.org Suggested-by: Stephen Boyd <sboyd@codeaurora.org> Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- Documentation/devicetree/bindings/power/opp.txt | 40 ++++++++++++------------- 1 file changed, 20 insertions(+), 20 deletions(-)