From patchwork Mon Sep 26 06:50:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Patchwork-Id: 674989 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sjGr22pfKz9s5w for ; Mon, 26 Sep 2016 18:10:58 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754976AbcIZIKz (ORCPT ); Mon, 26 Sep 2016 04:10:55 -0400 Received: from mo4.mail-out.ovh.net ([178.32.228.4]:51089 "EHLO mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbcIZIKx (ORCPT ); Mon, 26 Sep 2016 04:10:53 -0400 X-Greylist: delayed 3601 seconds by postgrey-1.27 at vger.kernel.org; Mon, 26 Sep 2016 04:10:53 EDT Received: from player691.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id F2F3A10DA1 for ; Mon, 26 Sep 2016 08:51:01 +0200 (CEST) Received: from hermes.kaod.org (LFbn-1-2234-107.w90-76.abo.wanadoo.fr [90.76.55.107]) (Authenticated sender: clg@kaod.org) by player691.ha.ovh.net (Postfix) with ESMTPSA id AE0EB26007C; Mon, 26 Sep 2016 08:50:48 +0200 (CEST) Subject: Re: [PATCH v3 1/3] ipmi: add an Aspeed BT IPMI BMC driver To: Rob Herring References: <1474354900-5618-1-git-send-email-clg@kaod.org> <1474354900-5618-2-git-send-email-clg@kaod.org> <20160923183421.GA14864@rob-hp-laptop> Cc: Corey Minyard , openipmi-developer@lists.sourceforge.net, Joel Stanley , Alistair Popple , Mark Rutland , Russell King , Arnd Bergmann , Jeremy Kerr , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: Date: Mon, 26 Sep 2016 08:50:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160923183421.GA14864@rob-hp-laptop> X-Ovh-Tracer-Id: 14219271398744493052 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelvddruddvgdduudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, On 09/23/2016 08:34 PM, Rob Herring wrote: > On Tue, Sep 20, 2016 at 09:01:38AM +0200, Cédric Le Goater wrote: >> From: Alistair Popple >> >> This patch adds a simple device driver to expose the iBT interface on >> Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are >> commonly used as BMCs (BaseBoard Management Controllers) and this >> driver implements the BMC side of the BT interface. >> >> The BT (Block Transfer) interface is used to perform in-band IPMI >> communication between a host and its BMC. Entire messages are buffered >> before sending a notification to the other end, host or BMC, that >> there is data to be read. Usually, the host emits requests and the BMC >> responses but the specification provides a mean for the BMC to send >> SMS Attention (BMC-to-Host attention or System Management Software >> attention) messages. >> >> For this purpose, the driver introduces a specific ioctl on the >> device: 'BT_BMC_IOCTL_SMS_ATN' that can be used by the system running >> on the BMC to signal the host of such an event. >> >> The device name defaults to '/dev/ipmi-bt-host' >> >> Signed-off-by: Alistair Popple >> Signed-off-by: Jeremy Kerr >> Signed-off-by: Joel Stanley >> [clg: - checkpatch fixes >> - added a devicetree binding documentation >> - replace 'bt_host' by 'bt_bmc' to reflect that the driver is >> the BMC side of the IPMI BT interface >> - renamed the device to 'ipmi-bt-host' >> - introduced a temporary buffer to copy_{to,from}_user >> - used platform_get_irq() >> - moved the driver under drivers/char/ipmi/ but kept it as a misc >> device >> - changed the compatible cell to "aspeed,ast2400-bt-bmc" >> ] >> Signed-off-by: Cédric Le Goater >> Acked-by: Arnd Bergmann >> [clg: - checkpatch --strict fixes >> - removed the use of devm_iounmap, devm_kfree in cleanup paths >> - introduced an atomic-t to limit opens to 1 >> - introduced a mutex to protect write/read operations] >> Signed-off-by: Cédric Le Goater >> >> --- >> >> Changes since v2: >> >> - fixed checkpatch --strict issues >> - cleanup'ed includes >> - limit to one opener >> - protect write/read operations with a mutex. >> - removed the use of devm_iounmap, devm_kfree in cleanup paths >> >> Changes since v1: >> >> - replace 'bt_host' by 'bt_bmc' to reflect that the driver is >> the BMC side of the IPMI BT interface >> - renamed the device to 'ipmi-bt-host' >> - introduced a temporary buffer to copy_{to,from}_user >> - used platform_get_irq() >> - moved the driver under drivers/char/ipmi/ but kept it as a misc >> device >> - changed the compatible cell to "aspeed,ast2400-bt-bmc" >> >> .../bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt | 23 + > > While similar, this is not the kernel directory structure. Just make > this bindings/ipmi/ > > With that, > > Acked-by: Rob Herring OK. So I suppose we should be moving all IPMI documentation under the same directory. Corey, If the move is okay for you, I can send the patch below. Thanks, C. >From ca25f89b25209c260480cda5e5532d6bbe83ed43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Mon, 26 Sep 2016 08:45:15 +0200 Subject: [PATCH] dt-bindings: ipmi: move all documentation under bindings/ipmi/ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Cédric Le Goater --- .../devicetree/bindings/{char => }/ipmi/aspeed,ast2400-bt-bmc.txt | 0 Documentation/devicetree/bindings/{ipmi.txt => ipmi/ipmi-smic.txt} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/{char => }/ipmi/aspeed,ast2400-bt-bmc.txt (100%) rename Documentation/devicetree/bindings/{ipmi.txt => ipmi/ipmi-smic.txt} (100%) diff --git a/Documentation/devicetree/bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-bt-bmc.txt similarity index 100% rename from Documentation/devicetree/bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt rename to Documentation/devicetree/bindings/ipmi/aspeed,ast2400-bt-bmc.txt diff --git a/Documentation/devicetree/bindings/ipmi.txt b/Documentation/devicetree/bindings/ipmi/ipmi-smic.txt similarity index 100% rename from Documentation/devicetree/bindings/ipmi.txt rename to Documentation/devicetree/bindings/ipmi/ipmi-smic.txt