| Message ID | b70afd25fc48ad4d677e4e53951f2138cd34b85e.1523351100.git.viresh.kumar@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | of: Don't create platform device for OPP tables | expand |
Quoting Viresh Kumar (2018-04-10 02:05:22) > The OPP tables are present as separate nodes, whose phandle is used in > the "operating-points-v2" property of devices. Currently the OF core > creates a platform device for the OPP table unconditionally, which is > not used by any kernel code. > > Skip creating OPP table platform devices. > > Reported-by: Stephen Boyd <sboyd@kernel.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 10, 2018 at 4:05 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > The OPP tables are present as separate nodes, whose phandle is used in > the "operating-points-v2" property of devices. Currently the OF core > creates a platform device for the OPP table unconditionally, which is > not used by any kernel code. > > Skip creating OPP table platform devices. > > Reported-by: Stephen Boyd <sboyd@kernel.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/of/platform.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index c00d81dfac0b..aaae5d90433d 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -356,6 +356,12 @@ static int of_platform_bus_create(struct device_node *bus, > return 0; > } > > + /* OPP tables have separate nodes, but we don't want devices for them */ > + if (unlikely(of_device_is_compatible(bus, "operating-points-v2"))) { Can you make this a match table instead. I could imagine we may have some other cases to add. > + pr_debug("%s() - skipping OPP node %pOF\n", __func__, bus); > + return 0; > + } > + > if (of_node_check_flag(bus, OF_POPULATED_BUS)) { > pr_debug("%s() - skipping %pOF, already populated\n", > __func__, bus); > -- > 2.15.0.194.g9af6a3dea062 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/of/platform.c b/drivers/of/platform.c index c00d81dfac0b..aaae5d90433d 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -356,6 +356,12 @@ static int of_platform_bus_create(struct device_node *bus, return 0; } + /* OPP tables have separate nodes, but we don't want devices for them */ + if (unlikely(of_device_is_compatible(bus, "operating-points-v2"))) { + pr_debug("%s() - skipping OPP node %pOF\n", __func__, bus); + return 0; + } + if (of_node_check_flag(bus, OF_POPULATED_BUS)) { pr_debug("%s() - skipping %pOF, already populated\n", __func__, bus);
The OPP tables are present as separate nodes, whose phandle is used in the "operating-points-v2" property of devices. Currently the OF core creates a platform device for the OPP table unconditionally, which is not used by any kernel code. Skip creating OPP table platform devices. Reported-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/of/platform.c | 6 ++++++ 1 file changed, 6 insertions(+)