| Message ID | a5509576e211bcf528e088f78e619575a26bbd8f.1747077616.git.Ryan.Wanner@microchip.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | SAMA7D65 Add support for Crypto, CAN and PWM | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 12 May 2025 12:27:27 -0700, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > Add DT bindings for SAMA7D65 SoC in atmel AES. > > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > --- > .../devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml:19:13: [warning] wrong indentation: expected 14 but found 12 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/a5509576e211bcf528e088f78e619575a26bbd8f.1747077616.git.Ryan.Wanner@microchip.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi, Ryan, On 12.05.2025 22:27, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > Add DT bindings for SAMA7D65 SoC in atmel AES. Would be good to improve the description here, e.g., specify differences, similarities b/w SAMA7D65 and SAM9X7 or SAM9G46. Same for other similar patches in this series. Thank you, Claudiu > > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > --- > .../devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > index 7dc0748444fd..1de4ee70a05f 100644 > --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > @@ -15,7 +15,9 @@ properties: > oneOf: > - const: atmel,at91sam9g46-aes > - items: > - - const: microchip,sam9x7-aes > + - enum: > + - microchip,sam9x7-aes > + - microchip,sama7d65-aes > - const: atmel,at91sam9g46-aes > > reg:
diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml index 7dc0748444fd..1de4ee70a05f 100644 --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml @@ -15,7 +15,9 @@ properties: oneOf: - const: atmel,at91sam9g46-aes - items: - - const: microchip,sam9x7-aes + - enum: + - microchip,sam9x7-aes + - microchip,sama7d65-aes - const: atmel,at91sam9g46-aes reg: