| Message ID | YIlYnDBVn0fggMe3@orolia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/2] dt-bindings: dma: add schema for altr,msgdma | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 28 Apr 2021 14:44:12 +0200, Olivier Dautricourt wrote: > - add schema for Altera mSGDMA bindings in devicetree. > - add myself as 'Odd fixes' maintainer for this driver > > Signed-off-by: Olivier Dautricourt <olivier.dautricourt@orolia.com> > --- > .../devicetree/bindings/dma/altr,msgdma.yaml | 62 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/altr,msgdma.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/dma/altr,msgdma.example.dts:21.54-27.11: Warning (unit_address_format): /example-0/dma-controller@0xff200b00: unit name should not have leading "0x" /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/altr,msgdma.example.dt.yaml: example-0: 'dma-controller@0xff200b00' does not match any of the regexes: '.*-names$', '.*-supply$', '^#.*-cells$', '^#[a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+(,[0-9a-fA-F]+)*$', '^__.*__$', 'pinctrl-[0-9]+' From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/dt-core.yaml See https://patchwork.ozlabs.org/patch/1471123 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/dma/altr,msgdma.yaml b/Documentation/devicetree/bindings/dma/altr,msgdma.yaml new file mode 100644 index 000000000000..8189b4fb5944 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/altr,msgdma.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/altr,msgdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Altera mSGDMA IP core + +maintainers: + - Olivier Dautricourt <olivier.dautricourt@orolia.com> + +description: | + Altera / Intel modular Scatter-Gather Direct Memory Access (mSGDMA) + intellectual property (IP) + +allOf: + - $ref: "dma-controller.yaml#" + +properties: + compatible: + const: altr,msgdma + + reg: + description: + csr, desc, resp resgisters + maxItems: 3 + minItems: 3 + + reg-names: + items: + - const: csr + - const: desc + - const: resp + + interrupts: + maxItems: 1 + + "#dma-cells": + description: | + The dma controller dicards the argument but one must be specified + to keep compatibility with dma-controller schema. + const: 1 + +required: + - compatible + - reg + - reg-names + - interrupts + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + msgdma_controller: dma-controller@0xff200b00 { + compatible = "altr,msgdma"; + reg = <0xff200b00 0x04>, <0xff200c00 0x04>, <0xff200d00 0x04>; + reg-names = "csr", "desc", "resp"; + interrupts = <0 67 IRQ_TYPE_LEVEL_HIGH>; + #dma-cells = <1>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 04e7de8c95be..b2f7158d811e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -782,6 +782,12 @@ M: Ley Foon Tan <ley.foon.tan@intel.com> S: Maintained F: drivers/mailbox/mailbox-altera.c +ALTERA MSGDMA IP CORE DRIVER +M: Olivier Dautricourt <olivier.dautricourt@orolia.com> +S: Odd Fixes +F: Documentation/devicetree/bindings/dma/altr,msgdma.yaml +F: drivers/dma/altera-msgdma.c + ALTERA PIO DRIVER M: Joyce Ooi <joyce.ooi@intel.com> L: linux-gpio@vger.kernel.org
- add schema for Altera mSGDMA bindings in devicetree. - add myself as 'Odd fixes' maintainer for this driver Signed-off-by: Olivier Dautricourt <olivier.dautricourt@orolia.com> --- .../devicetree/bindings/dma/altr,msgdma.yaml | 62 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/altr,msgdma.yaml -- 2.31.0.rc2