| Message ID | 42d04e9ec43d10f978cee1dd974bbfdccf121d85.1659985696.git.danielrparks@ti.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add SA2UL Public Key Accelerator driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 08/08/2022 22:12, Daniel Parks wrote: > The PKA (aka eip29t2) is a subdevice of the SA2UL on k3. > > Signed-off-by: Daniel Parks <danielrparks@ti.com> > --- > Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > index 02f47c2e7998..e4adb8192608 100644 > --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > @@ -64,8 +64,14 @@ patternProperties: > type: object > description: > Child RNG node for SA2UL > > +patternProperties: > + "^pka@[a-f0-9]+$": > + type: object > + description: > + Child PKA node for SA2UL If PKA is from "Public Key Accelerator", could you include here full name of the abbreviation? Anyway you need here reference to schema for your node or describe the contents. Best regards, Krzysztof
On Mon, 08 Aug 2022 14:12:50 -0500, Daniel Parks wrote: > The PKA (aka eip29t2) is a subdevice of the SA2UL on k3. > > Signed-off-by: Daniel Parks <danielrparks@ti.com> > --- > Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml:68:1: [error] duplication of key "patternProperties" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/crypto/ti,sa2ul.example.dts' Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml:68:1: found duplicate key "patternProperties" with value "{}" (original value: "{}") make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/crypto/ti,sa2ul.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml:68:1: found duplicate key "patternProperties" with value "{}" (original value: "{}") /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml: ignoring, error parsing file make: *** [Makefile:1404: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml index 02f47c2e7998..e4adb8192608 100644 --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml @@ -64,8 +64,14 @@ patternProperties: type: object description: Child RNG node for SA2UL +patternProperties: + "^pka@[a-f0-9]+$": + type: object + description: + Child PKA node for SA2UL + required: - compatible - reg - power-domains
The PKA (aka eip29t2) is a subdevice of the SA2UL on k3. Signed-off-by: Daniel Parks <danielrparks@ti.com> --- Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 6 ++++++ 1 file changed, 6 insertions(+)