| Message ID | 2de75a74ef4086090c532d3b80b7d6dcd115e45e.1569474867.git.shubhrajyoti.datta@xilinx.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [RFC,PATCHv2,1/3] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Sep 26, 2019 at 10:46:24AM +0530, Shubhrajyoti Datta wrote: > Add dt bindings for flexnoc Performance Monitor. > The flexnoc counters for read and write response and requests are > supported. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt <snip> Why are these "RFC"? I guess you don't want them merged because you are not thinking that they are good enough? What needs to be done on them that you are sending them out now? greg k-h
On Thu, Sep 26, 2019 at 10:46:24AM +0530, Shubhrajyoti Datta wrote: > Add dt bindings for flexnoc Performance Monitor. > The flexnoc counters for read and write response and requests are > supported. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++++++++++++++++++++++ bindings/perf/ Please convert this to a schema. See Documentation/devicetree/writing-schema.rst. > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt > > diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt > new file mode 100644 > index 0000000..6b533bc > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt > @@ -0,0 +1,24 @@ > +* Xilinx Flexnoc Performance Monitor driver Bindings are for h/w blocks, not drivers. > + > +The FlexNoc Performance Monitor has counters for monitoring > +the read and the write transaction counter. > + > +Required properties: > +- compatible: "xlnx,flexnoc-pm-2.7" > +- reg : Address and length of register sets for each device in > + "reg-names" > +- reg-names : The names of the register addresses corresponding to the > + registers filled in "reg" > + - funnel: base address of the funnel registers > + - baselpd: base address of the LPD PM registers > + - basefpd: base address FPD PM registers Is this really all one h/w block. FlexNoC is an interconnect, right? Is there more to it than just perfmon? > + > +Example: > +++++++++ > +performance-monitor@f0920000 { > + compatible = "xlnx,flexnoc-pm-2.7"; > + reg-names = "funnel", "baselpd", "basefpd"; > + reg = <0x0 0xf0920000 0x0 0x1000>, > + <0x0 0xf0980000 0x0 0x9000>, > + <0x0 0xf0b80000 0x0 0x9000>; > +}; > -- > 2.1.1 > > This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. We can't accept confidential emails. Rob
Hi, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Friday, October 11, 2019 3:19 AM > To: Shubhrajyoti Datta <shubhraj@xilinx.com> > Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > arnd@arndb.de; gregkh@linuxfoundation.org; Michal Simek > <michals@xilinx.com> > Subject: Re: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc > Performance Monitor > > On Thu, Sep 26, 2019 at 10:46:24AM +0530, Shubhrajyoti Datta wrote: > > Add dt bindings for flexnoc Performance Monitor. > > The flexnoc counters for read and write response and requests are > > supported. > > > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > --- > > .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 > ++++++++++++++++++++++ > > bindings/perf/ > > Please convert this to a schema. See > Documentation/devicetree/writing-schema.rst. Ok > > > 1 file changed, 24 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt > > > > diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt > > b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt > > new file mode 100644 > > index 0000000..6b533bc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt > > @@ -0,0 +1,24 @@ > > +* Xilinx Flexnoc Performance Monitor driver > > Bindings are for h/w blocks, not drivers. Wil change > > > + > > +The FlexNoc Performance Monitor has counters for monitoring the read > > +and the write transaction counter. > > + > > +Required properties: > > +- compatible: "xlnx,flexnoc-pm-2.7" > > +- reg : Address and length of register sets for each device in > > + "reg-names" > > +- reg-names : The names of the register addresses corresponding to the > > + registers filled in "reg" > > + - funnel: base address of the funnel registers > > + - baselpd: base address of the LPD PM registers > > + - basefpd: base address FPD PM registers > > Is this really all one h/w block. > > FlexNoC is an interconnect, right? Is there more to it than just perfmon? Yes , however the driver only uses the monitoring part. > > > +
diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt new file mode 100644 index 0000000..6b533bc --- /dev/null +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt @@ -0,0 +1,24 @@ +* Xilinx Flexnoc Performance Monitor driver + +The FlexNoc Performance Monitor has counters for monitoring +the read and the write transaction counter. + +Required properties: +- compatible: "xlnx,flexnoc-pm-2.7" +- reg : Address and length of register sets for each device in + "reg-names" +- reg-names : The names of the register addresses corresponding to the + registers filled in "reg" + - funnel: base address of the funnel registers + - baselpd: base address of the LPD PM registers + - basefpd: base address FPD PM registers + +Example: +++++++++ +performance-monitor@f0920000 { + compatible = "xlnx,flexnoc-pm-2.7"; + reg-names = "funnel", "baselpd", "basefpd"; + reg = <0x0 0xf0920000 0x0 0x1000>, + <0x0 0xf0980000 0x0 0x9000>, + <0x0 0xf0b80000 0x0 0x9000>; +};
Add dt bindings for flexnoc Performance Monitor. The flexnoc counters for read and write response and requests are supported. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> --- .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt -- 2.1.1 This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.